Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

Issue 2304943003: [Android]Fix a regression that snackbar sits behind the scrim (Closed)
Patch Set: add proguard config Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
index a5a08e38a5f3a91c9be7c5906a611df50550566c..5ff9ded909992a2c5d59009488436cf7b15bfc2d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
@@ -226,7 +226,8 @@ public class CompositorViewHolder extends CoordinatorLayout
});
mCompositorView = new CompositorView(getContext(), this);
- addView(mCompositorView,
+ // mCompositorView should always be the first child.
+ addView(mCompositorView, 0,
new FrameLayout.LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.WRAP_CONTENT));
}
@@ -811,9 +812,11 @@ public class CompositorViewHolder extends CoordinatorLayout
LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT);
}
layoutParams.setBehavior(mView.getBehavior());
- // CompositorView has index of 0; TabContentViewParent has index of 1; Snackbar (if
- // any) has index of 2. Setting index here explicitly to avoid TabContentViewParent
- // hiding the snackbar.
+ // CompositorView has index of 0; TabContentViewParent has index of 1; omnibox
+ // result container (the scrim) has index of 2, Snackbar (if any) has index of 3.
+ // Setting index here explicitly to avoid TabContentViewParent hiding the scrim.
+ // TODO(ianwen): Use more advanced technologies to ensure z-order of the children of
+ // this class, instead of hard-coding.
addView(mView, 1, layoutParams);
setFocusable(false);

Powered by Google App Engine
This is Rietveld 408576698