Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2304833002: Merge 2840: Fix removeChildNode to unmark orthogonal writing mode roots when !notifyLayoutObject (Closed)

Created:
4 years, 3 months ago by kojii
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Merge 2840: Fix removeChildNode to unmark orthogonal writing mode roots when !notifyLayoutObject removeChildNode() does not notify willBeRemovedFromTree() when !notifyLayoutObject. This can leave orthogonal writing mode roots marked after the removal of the child. This patch unmarks them even when !notifyLayoutObject. This fixes annonymous boxes left marked in fullscreen. It is still correct for LayoutFullscreen to have the same writing-mode as parent, but DCHECK was removed because it doesn't leave boxes unmarked any longer, and ensuring that against dynamic changes requires more work. BUG=642028 Review-Url: https://codereview.chromium.org/2296973003 Cr-Commit-Position: refs/heads/master@{#415675} (cherry picked from commit 146cecaf22dca2a82fa102c46441af6bd79dffa0) Committed: https://chromium.googlesource.com/chromium/src/+/39e06039f343ece335a0eaf610d2ce577f110a6c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kojii
4 years, 3 months ago (2016-09-02 05:05:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
39e06039f343ece335a0eaf610d2ce577f110a6c.

Powered by Google App Engine
This is Rietveld 408576698