Chromium Code Reviews
DescriptionMerge 2840: Fix removeChildNode to unmark orthogonal writing mode roots when !notifyLayoutObject
removeChildNode() does not notify willBeRemovedFromTree() when
!notifyLayoutObject. This can leave orthogonal writing mode roots
marked after the removal of the child.
This patch unmarks them even when !notifyLayoutObject.
This fixes annonymous boxes left marked in fullscreen. It is still
correct for LayoutFullscreen to have the same writing-mode as parent,
but DCHECK was removed because it doesn't leave boxes unmarked any
longer, and ensuring that against dynamic changes requires more work.
BUG=642028
Review-Url: https://codereview.chromium.org/2296973003
Cr-Commit-Position: refs/heads/master@{#415675}
(cherry picked from commit 146cecaf22dca2a82fa102c46441af6bd79dffa0)
Committed: https://chromium.googlesource.com/chromium/src/+/39e06039f343ece335a0eaf610d2ce577f110a6c
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
||||||||||||||||||||||||||||