Fix removeChildNode to unmark orthogonal writing mode roots when !notifyLayoutObject

Fix removeChildNode to unmark orthogonal writing mode roots when !notifyLayoutObject

removeChildNode() does not notify willBeRemovedFromTree() when
!notifyLayoutObject. This can leave orthogonal writing mode roots
marked after the removal of the child.

This patch unmarks them even when !notifyLayoutObject.

This fixes annonymous boxes left marked in fullscreen. It is still
correct for LayoutFullscreen to have the same writing-mode as parent,
but DCHECK was removed because it doesn't leave boxes unmarked any
longer, and ensuring that against dynamic changes requires more work.

BUG=642028
Committed: https://crrev.com/146cecaf22dca2a82fa102c46441af6bd79dffa0
Cr-Commit-Position: refs/heads/master@{#415675}

[kojii, 2016-08-31 07:25:47]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 07:26:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-08-31 07:33:59]

Description was changed from

==========
fullscreen

BUG=
==========

to

==========
Fix removeChildNode to unmark orthogonal writing mode roots when
!notifyLayoutObject

removeChildNode() does not notify willBeRemovedFromTree() when
!notifyLayoutObject. This can leave orthogonal writing mode roots
marked after the removal of the child.

This patch unmarks them even when !notifyLayoutObject.

BUG=642028
==========

[kojii, 2016-08-31 07:39:19]

Description was changed from

==========
Fix removeChildNode to unmark orthogonal writing mode roots when
!notifyLayoutObject

removeChildNode() does not notify willBeRemovedFromTree() when
!notifyLayoutObject. This can leave orthogonal writing mode roots
marked after the removal of the child.

This patch unmarks them even when !notifyLayoutObject.

BUG=642028
==========

to

==========
Fix removeChildNode to unmark orthogonal writing mode roots when
!notifyLayoutObject

removeChildNode() does not notify willBeRemovedFromTree() when
!notifyLayoutObject. This can leave orthogonal writing mode roots
marked after the removal of the child.

This patch unmarks them even when !notifyLayoutObject.

This fixes annonymous boxes left marked in fullscreen. It is still
correct for LayoutFullscreen to have the same writing-mode as parent,
but DCHECK was removed because it doesn't leave boxes unmarked any
longer, and ensuring that against dynamic changes requires more work.

BUG=642028
==========

[commit-bot: I haz the power, 2016-08-31 09:30:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 09:30:01]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kojii, 2016-08-31 15:03:22]

kojii@chromium.org changed reviewers:
+ eae@chromium.org

[kojii, 2016-08-31 15:03:23]

PTAL.

I believe this is the root cause of fullscreen issues, sorry to took so long and
multiple CLs to figure it out.

Keeping the same writing-mode is still helpful for the correctness, so I keep
them.

[eae, 2016-08-31 16:07:29]

Yay, LGTM!

[eae, 2016-08-31 16:08:44]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-08-31 16:09:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 17:39:21]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-31 17:40:59]

Description was changed from

==========
Fix removeChildNode to unmark orthogonal writing mode roots when
!notifyLayoutObject

removeChildNode() does not notify willBeRemovedFromTree() when
!notifyLayoutObject. This can leave orthogonal writing mode roots
marked after the removal of the child.

This patch unmarks them even when !notifyLayoutObject.

This fixes annonymous boxes left marked in fullscreen. It is still
correct for LayoutFullscreen to have the same writing-mode as parent,
but DCHECK was removed because it doesn't leave boxes unmarked any
longer, and ensuring that against dynamic changes requires more work.

BUG=642028
==========

to

==========
Fix removeChildNode to unmark orthogonal writing mode roots when
!notifyLayoutObject

removeChildNode() does not notify willBeRemovedFromTree() when
!notifyLayoutObject. This can leave orthogonal writing mode roots
marked after the removal of the child.

This patch unmarks them even when !notifyLayoutObject.

This fixes annonymous boxes left marked in fullscreen. It is still
correct for LayoutFullscreen to have the same writing-mode as parent,
but DCHECK was removed because it doesn't leave boxes unmarked any
longer, and ensuring that against dynamic changes requires more work.

BUG=642028

Committed: https://crrev.com/146cecaf22dca2a82fa102c46441af6bd79dffa0
Cr-Commit-Position: refs/heads/master@{#415675}
==========

[commit-bot: I haz the power, 2016-08-31 17:41:00]

Patchset 1 (id:??) landed as
https://crrev.com/146cecaf22dca2a82fa102c46441af6bd79dffa0
Cr-Commit-Position: refs/heads/master@{#415675}