Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: components/crash/content/browser/crash_dump_observer_android.cc

Issue 2304733002: crash: Fixes following r413431 (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/crash/content/browser/crash_dump_observer_android.cc
diff --git a/components/crash/content/browser/crash_dump_observer_android.cc b/components/crash/content/browser/crash_dump_observer_android.cc
index a7acdd89e51be855804d61aeb8f18473adb31c34..6cfaab7924e3e9a5d3f1cba71af519212155361b 100644
--- a/components/crash/content/browser/crash_dump_observer_android.cc
+++ b/components/crash/content/browser/crash_dump_observer_android.cc
@@ -32,6 +32,7 @@ CrashDumpObserver::CrashDumpObserver() {
notification_registrar_.Add(this,
content::NOTIFICATION_RENDERER_PROCESS_CLOSED,
content::NotificationService::AllSources());
+ BrowserChildProcessObserver::Add(this);
Lei Zhang 2016/09/01 23:17:58 Does the dtor need a BrowserChildProcessObserver::
boliu 2016/09/01 23:26:18 Ahh, good point. Done (Although.. this is android
Lei Zhang 2016/09/01 23:30:44 Right, just wondering what the policy is on Androi
}
CrashDumpObserver::~CrashDumpObserver() {}

Powered by Google App Engine
This is Rietveld 408576698