crash: Fixes following r413431

components/crash/content/browser/crash_dump_observer_android.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/crash/content/browser/crash_dump_observer_android.h"
 
 #include <unistd.h>
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/stl_util.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/child_process_data.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_process_host.h"
 
 using content::BrowserThread;
 
 namespace breakpad {
 
 // static
 CrashDumpObserver* CrashDumpObserver::GetInstance() {
   return base::Singleton<CrashDumpObserver>::get();

[Lei Zhang, 2016/09/01 23:17:58]

For later, I guess. Speaking of Singletons, is it really necessary? (See top of
singleton.h)

[boliu, 2016/09/01 23:26:18]

Err, I'll leave that one to original CL author.

Probably possible to place inside some other global object (eg
ContentBrowserClient?), but changing lifetime of this object could imply not
catching crashes on shutdown?

But otoh, this is android and there is no such thing as shutdown.

[Lei Zhang, 2016/09/01 23:30:44]

Right, not directed at you.
I was just thinking of using a LazyInstance instead.

 }
 
 CrashDumpObserver::CrashDumpObserver() {
   notification_registrar_.Add(this,
                               content::NOTIFICATION_RENDERER_PROCESS_TERMINATED,
                               content::NotificationService::AllSources());
   notification_registrar_.Add(this,
                               content::NOTIFICATION_RENDERER_PROCESS_CLOSED,
                               content::NotificationService::AllSources());
+  BrowserChildProcessObserver::Add(this);

[Lei Zhang, 2016/09/01 23:17:58]

Does the dtor need a BrowserChildProcessObserver::Remove(this) call to balance
this? Or does it not matter because this class is a Singleton?

[boliu, 2016/09/01 23:26:18]

Ahh, good point. Done

(Although.. this is android, globals are never going to be cleaned up..)

[Lei Zhang, 2016/09/01 23:30:44]

Right, just wondering what the policy is on Android.

 }
 
 CrashDumpObserver::~CrashDumpObserver() {}
 
 void CrashDumpObserver::OnChildExitOnBlockingPool(
     Client* client,
     int child_process_id,
     base::ProcessHandle pid,
     content::ProcessType process_type,
     base::TerminationStatus termination_status,
@@ skipping 98 matching lines @@
     default:
       NOTREACHED();
       return;
   }
 
   OnChildExit(rph->GetID(), rph->GetHandle(), content::PROCESS_TYPE_RENDERER,
               term_status, app_state);
 }
 
 }  // namespace breakpad