Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2304483002: Revert of Make cc::Display not own its BeginFrameSource (Closed)

Created:
4 years, 3 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 3 months ago
CC:
anandc+watch-blimp_chromium.org, cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, dtrainor+watch-blimp_chromium.org, Fady Samuel, gcasto+watch-blimp_chromium.org, jam, jbauman+watch_chromium.org, jessicag+watch-blimp_chromium.org, kalyank, khushalsagar+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, piman+watch_chromium.org, rjkroege, shaktisahu+watch-blimp_chromium.org, sievers+watch_chromium.org, sriramsr+watch-blimp_chromium.org, Ian Vollick
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make cc::Display not own its BeginFrameSource (patchset #5 id:80001 of https://codereview.chromium.org/2286273003/ ) Reason for revert: Suspect this may have induced renderer crashes in the context_lost tests; see http://crbug.com/642984 . Original issue's description: > Make cc::Display not own its BeginFrameSource > > This is refactoring to allow MusBrowserCompositorOutputSurface to > provide an ExternalBeginFrameSource that it owns rather than > passing ownership to Display. > > This should also make it possible to remove begin frame sources from > OutputSurface in the future after the OutputSurface/CompositorFrameSink > split. > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/9848a61393772cc8a9aa8349c68f7d436c743369 > Cr-Commit-Position: refs/heads/master@{#415738} TBR=boliu@chromium.org,danakj@chromium.org,fsamuel@chromium.org,nyquist@chromium.org,sievers@chromium.org,enne@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/97ecf8ee67f2ce4a10bdd11c99c5fd83f2da8934 Cr-Commit-Position: refs/heads/master@{#415813}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -71 lines) Patch
M android_webview/browser/surfaces_instance.h View 2 chunks +0 lines, -2 lines 0 comments Download
M android_webview/browser/surfaces_instance.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M blimp/client/app/compositor/browser_compositor.h View 2 chunks +0 lines, -2 lines 0 comments Download
M blimp/client/app/compositor/browser_compositor.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M cc/surfaces/display.h View 3 chunks +4 lines, -2 lines 0 comments Download
M cc/surfaces/display.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M cc/surfaces/display_unittest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M cc/surfaces/surface_display_output_surface_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M cc/test/test_delegating_output_surface.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/test_delegating_output_surface.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M services/ui/surfaces/display_compositor.h View 2 chunks +0 lines, -2 lines 0 comments Download
M services/ui/surfaces/display_compositor.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M ui/compositor/test/in_process_context_factory.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/compositor/test/in_process_context_factory.cc View 3 chunks +13 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Ken Russell (switch to Gerrit)
Created Revert of Make cc::Display not own its BeginFrameSource
4 years, 3 months ago (2016-09-01 00:08:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2304483002/1
4 years, 3 months ago (2016-09-01 00:08:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 00:10:24 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 00:13:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97ecf8ee67f2ce4a10bdd11c99c5fd83f2da8934
Cr-Commit-Position: refs/heads/master@{#415813}

Powered by Google App Engine
This is Rietveld 408576698