Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1386)

Unified Diff: content/browser/renderer_host/compositor_impl_android.cc

Issue 2304483002: Revert of Make cc::Display not own its BeginFrameSource (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/compositor_impl_android.h ('k') | services/ui/surfaces/display_compositor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/compositor_impl_android.cc
diff --git a/content/browser/renderer_host/compositor_impl_android.cc b/content/browser/renderer_host/compositor_impl_android.cc
index 05eef394cea50bb35efec0fcc6aad541d40e3ea9..64ed74c16081a91a691be298cd48ce05a3e575d1 100644
--- a/content/browser/renderer_host/compositor_impl_android.cc
+++ b/content/browser/renderer_host/compositor_impl_android.cc
@@ -682,7 +682,8 @@
cc::SurfaceManager* manager =
ui::ContextProviderFactory::GetInstance()->GetSurfaceManager();
auto* task_runner = base::ThreadTaskRunnerHandle::Get().get();
- auto begin_frame_source = base::MakeUnique<ExternalBeginFrameSource>(this);
+ std::unique_ptr<ExternalBeginFrameSource> begin_frame_source(
+ new ExternalBeginFrameSource(this));
std::unique_ptr<cc::DisplayScheduler> scheduler(new cc::DisplayScheduler(
begin_frame_source.get(), task_runner,
display_output_surface->capabilities().max_frames_pending));
@@ -690,10 +691,9 @@
display_.reset(new cc::Display(
HostSharedBitmapManager::current(),
BrowserGpuMemoryBufferManager::current(),
- host_->settings().renderer_settings, begin_frame_source.get(),
+ host_->settings().renderer_settings, std::move(begin_frame_source),
std::move(display_output_surface), std::move(scheduler),
base::MakeUnique<cc::TextureMailboxDeleter>(task_runner)));
- begin_frame_source_ = std::move(begin_frame_source);
std::unique_ptr<cc::SurfaceDisplayOutputSurface> delegated_output_surface(
vulkan_context_provider ? new cc::SurfaceDisplayOutputSurface(
« no previous file with comments | « content/browser/renderer_host/compositor_impl_android.h ('k') | services/ui/surfaces/display_compositor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698