Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issue 230443004: Remove V8_ALLOW_ACCESS_TO_RAW_HANDLE_CONSTRUCTOR. (Closed)

Created:
6 years, 8 months ago by vogelheim
Modified:
6 years, 8 months ago
Reviewers:
dcarney
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove V8_ALLOW_ACCESS_TO_RAW_HANDLE_CONSTRUCTOR. The usage of this define has been obsoleted by removal of UnsafePersistent from Chromium. Depends on https://codereview.chromium.org/230613005 R=dcarney@chromium.org BUG=276323 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=20656

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -24 lines) Patch
M include/v8.h View 6 chunks +8 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
vogelheim
Minor cleanup. I won't be able to check-in until the usages in Chromium have been ...
6 years, 8 months ago (2014-04-09 13:57:17 UTC) #1
dcarney
lgtm
6 years, 8 months ago (2014-04-09 13:58:10 UTC) #2
vogelheim
The CQ bit was checked by vogelheim@chromium.org
6 years, 8 months ago (2014-04-09 16:03:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://v8-status.appspot.com/cq/vogelheim@chromium.org/230443004/1
6 years, 8 months ago (2014-04-09 16:03:20 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-09 16:03:21 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-04-09 16:03:21 UTC) #6
vogelheim
6 years, 8 months ago (2014-04-10 13:51:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r20656 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698