Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 230613005: Cleanup: Remove unnecessary define, since UnsafePersistent has indeed been removed. (Closed)

Created:
6 years, 8 months ago by vogelheim
Modified:
6 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Cleanup: Remove unnecessary define, since UnsafePersistent has indeed been removed. R=dcarney@chromium.org R=jochen@chromium.org (OWNERS) BUG=276323 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262957

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M chrome/renderer/extensions/object_backed_native_handler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/v8_schema_registry.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/web_ax_object_proxy.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
vogelheim
Minor cleanup.
6 years, 8 months ago (2014-04-09 13:54:49 UTC) #1
dcarney
lgtm
6 years, 8 months ago (2014-04-09 13:57:11 UTC) #2
dcarney
can you remove it from v8.h as well. it should be possible to do now
6 years, 8 months ago (2014-04-09 13:57:38 UTC) #3
vogelheim
Removal from v8.h is in a separate CL.
6 years, 8 months ago (2014-04-09 13:59:22 UTC) #4
vogelheim
The CQ bit was checked by vogelheim@chromium.org
6 years, 8 months ago (2014-04-09 14:09:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vogelheim@chromium.org/230613005/1
6 years, 8 months ago (2014-04-09 14:09:26 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-09 14:57:36 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=60352
6 years, 8 months ago (2014-04-09 14:57:37 UTC) #8
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-10 09:26:34 UTC) #9
vogelheim
The CQ bit was checked by vogelheim@chromium.org
6 years, 8 months ago (2014-04-10 09:28:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vogelheim@chromium.org/230613005/1
6 years, 8 months ago (2014-04-10 09:28:41 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 13:16:12 UTC) #12
Message was sent while issue was closed. 
Change committed as 262957

Powered by Google App Engine
This is Rietveld 408576698