Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1049)

Issue 2304303002: Inline GYP sources for chrome/ android and chromeos. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, alemate+watch_chromium.org, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, samuong+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Inline GYP sources for chrome/ android and chromeos. Delete corresponding GYP files. TBR=dpranke CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/25093403aab97ecbf2864d13af572d679ddf7f6b Cr-Commit-Position: refs/heads/master@{#416424}

Patch Set 1 #

Patch Set 2 : delete #

Patch Set 3 : merge #

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1389 lines, -2530 lines) Patch
M .gn View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/android/BUILD.gn View 3 20 chunks +64 lines, -46 lines 0 comments Download
D chrome/android/chrome_apk.gyp View 1 chunk +0 lines, -423 lines 0 comments Download
D chrome/android/chrome_apk.gypi View 1 chunk +0 lines, -43 lines 0 comments Download
M chrome/browser/chromeos/BUILD.gn View 2 chunks +1150 lines, -10 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/BUILD.gn View 7 chunks +175 lines, -46 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/chromevox_assets.gypi View 1 chunk +0 lines, -139 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi View 1 1 chunk +0 lines, -291 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/chromevox_vars.gypi View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/chrome_android_paks.gypi View 1 chunk +0 lines, -110 lines 0 comments Download
D chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -1390 lines 0 comments Download
M chrome/test/chromedriver/BUILD.gn View 5 chunks +0 lines, -9 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (12 generated)
brettw
delete
4 years, 3 months ago (2016-09-02 21:08:46 UTC) #2
brettw
4 years, 3 months ago (2016-09-02 21:09:32 UTC) #5
brettw
merge
4 years, 3 months ago (2016-09-02 21:24:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2304303002/40001
4 years, 3 months ago (2016-09-02 21:24:56 UTC) #12
commit-bot: I haz the power
Failed to apply patch for chrome/android/BUILD.gn: While running git apply --index -3 -p1; error: patch ...
4 years, 3 months ago (2016-09-02 23:41:08 UTC) #14
brettw
merge
4 years, 3 months ago (2016-09-02 23:54:29 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2304303002/60001
4 years, 3 months ago (2016-09-02 23:55:16 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-03 01:11:29 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-03 01:15:03 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/25093403aab97ecbf2864d13af572d679ddf7f6b
Cr-Commit-Position: refs/heads/master@{#416424}

Powered by Google App Engine
This is Rietveld 408576698