Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2312443002:
Inline chrome_tests_unit.gypi in the GN build. (Closed)
|
Created:
4 years, 3 months ago by brettw Modified:
4 years, 3 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews, samuong+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionInline chrome_tests_unit.gypi in the GN build.
Remove associated obsolete infrastructure.
TBR=dpranke
Committed: https://crrev.com/22ef37e00e7322c569d5e7992fcd2f768b713c13
Cr-Commit-Position: refs/heads/master@{#416478}
Patch Set 1 #Patch Set 2 : Merge #Patch Set 3 : Merge + fix ChromeOS paths. #Patch Set 4 : Fix CrOS #
Messages
Total messages: 38 (23 generated)
Description was changed from ========== Inline chrome_tests_unit.gypi in the GN build. Remove associated obsolete infrastructure. ========== to ========== Inline chrome_tests_unit.gypi in the GN build. Remove associated obsolete infrastructure. TBR=dpranke ==========
brettw@chromium.org changed reviewers: + dpranke@chromium.org
The CQ bit was checked by brettw@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2304303002 Patch 40001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by brettw@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by brettw@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Merge + fix ChromeOS paths.
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Fix CrOS
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Inline chrome_tests_unit.gypi in the GN build. Remove associated obsolete infrastructure. TBR=dpranke ========== to ========== Inline chrome_tests_unit.gypi in the GN build. Remove associated obsolete infrastructure. TBR=dpranke ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Inline chrome_tests_unit.gypi in the GN build. Remove associated obsolete infrastructure. TBR=dpranke ========== to ========== Inline chrome_tests_unit.gypi in the GN build. Remove associated obsolete infrastructure. TBR=dpranke Committed: https://crrev.com/22ef37e00e7322c569d5e7992fcd2f768b713c13 Cr-Commit-Position: refs/heads/master@{#416478} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/22ef37e00e7322c569d5e7992fcd2f768b713c13 Cr-Commit-Position: refs/heads/master@{#416478}
Message was sent while issue was closed.
lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
