Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2304053002: Fix invocation of git_cl.run() in DepsUpdater.write_test_expectations. (Closed)

Created:
4 years, 3 months ago by qyearsley
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix invocation of git_cl.run() in DepsUpdater.write_test_expectations. This isn't caught by the unit test because it's not tested; it's questionable whether it's worth adding a unit test for that function as it is now, since that method just invokes some external commands. This issue was caught by looking at the latest failures on w3c-test-autoroller. BUG=629275 Committed: https://crrev.com/905922aa31995068d026594cd86a7c8aa95578d7 Cr-Commit-Position: refs/heads/master@{#416288}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
qyearsley
4 years, 3 months ago (2016-09-02 04:02:14 UTC) #2
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-02 04:13:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2304053002/1
4 years, 3 months ago (2016-09-02 15:57:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 17:16:27 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 17:18:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/905922aa31995068d026594cd86a7c8aa95578d7
Cr-Commit-Position: refs/heads/master@{#416288}

Powered by Google App Engine
This is Rietveld 408576698