third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py - Issue 2304053002: Fix invocation of git_cl.run() in DepsUpdater.write_test_expectations.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py

Issue 2304053002: Fix invocation of git_cl.run() in DepsUpdater.write_test_expectations. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | no next file » | no next file with comments »

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Fetches a copy of the latest state of a W3C test repository and commits.	5 """Fetches a copy of the latest state of a W3C test repository and commits.

6	6

7 If this script is given the argument --auto-update, it will also attempt to	7 If this script is given the argument --auto-update, it will also attempt to

8 upload a CL, triggery try jobs, and make any changes that are required for	8 upload a CL, triggery try jobs, and make any changes that are required for

9 new failing tests before committing.	9 new failing tests before committing.

10 """	10 """

(...skipping 340 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
351 if test_dir in directory_to_owner:	351 if test_dir in directory_to_owner:

352 email_addresses.add(directory_to_owner[test_dir])	352 email_addresses.add(directory_to_owner[test_dir])

353 return sorted(email_addresses)	353 return sorted(email_addresses)

354	354

355 def write_test_expectations(self):	355 def write_test_expectations(self):

356 self.print_('## Adding test expectations lines to LayoutTests/TestExpect ations.')	356 self.print_('## Adding test expectations lines to LayoutTests/TestExpect ations.')

357 script_path = self.path_from_webkit_base('Tools', 'Scripts', 'update-w3c -test-expectations')	357 script_path = self.path_from_webkit_base('Tools', 'Scripts', 'update-w3c -test-expectations')

358 self.run([self.host.executable, script_path])	358 self.run([self.host.executable, script_path])

359 message = '\'Modifies TestExpectations and/or downloads new baselines fo r tests\''	359 message = '\'Modifies TestExpectations and/or downloads new baselines fo r tests\''

360 self.check_run(['git', 'commit', '-a', '-m', message])	360 self.check_run(['git', 'commit', '-a', '-m', message])

361 self.git_cl(['upload', '-m', message, '--rietveld'])	361 self.git_cl.run(['upload', '-m', message, '--rietveld'])

OLD	NEW