Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 2304023002: Use StringView in History.cpp (Closed)

Created:
4 years, 3 months ago by esprehn
Modified:
4 years, 3 months ago
Reviewers:
haraken, dcheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use StringView in History.cpp This code wants to compare the prefix of two strings together, we can do that with StringView and use the much faster string equals methods that use memchr. BUG=615174 Committed: https://crrev.com/64b7b9d6b9a3280676c7e1d6c02d15fa3805f9c7 Cr-Commit-Position: refs/heads/master@{#416221}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -26 lines) Patch
M third_party/WebKit/Source/core/frame/History.cpp View 2 chunks +3 lines, -26 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
esprehn
4 years, 3 months ago (2016-09-02 02:39:40 UTC) #6
dcheng
lgtm
4 years, 3 months ago (2016-09-02 03:16:52 UTC) #7
haraken
LGTM
4 years, 3 months ago (2016-09-02 03:19:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2304023002/1
4 years, 3 months ago (2016-09-02 09:29:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 09:34:14 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 09:37:22 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64b7b9d6b9a3280676c7e1d6c02d15fa3805f9c7
Cr-Commit-Position: refs/heads/master@{#416221}

Powered by Google App Engine
This is Rietveld 408576698