Use StringView in History.cpp

third_party/WebKit/Source/core/frame/History.cpp

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 19 matching lines @@
 #include "core/frame/LocalFrame.h"
 #include "core/loader/DocumentLoader.h"
 #include "core/loader/FrameLoader.h"
 #include "core/loader/FrameLoaderClient.h"
 #include "core/loader/HistoryItem.h"
 #include "core/loader/NavigationScheduler.h"
 #include "core/page/Page.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/weborigin/KURL.h"
 #include "platform/weborigin/SecurityOrigin.h"
+#include "wtf/text/StringView.h"
 
 namespace blink {
 
 namespace {
 
 bool equalIgnoringPathQueryAndFragment(const KURL& a, const KURL& b)
 {
-    int aLength = a.pathStart();
-    int bLength = b.pathStart();
-
-    if (aLength != bLength)
-        return false;
-
-    const String& aString = a.getString();
-    const String& bString = b.getString();
-    for (int i = 0; i < aLength; ++i) {
-        if (aString[i] != bString[i])
-            return false;
-    }
-    return true;
+    return StringView(a.getString(), 0, a.pathStart()) == StringView(b.getString(), 0, b.pathStart());
 }
 
 bool equalIgnoringQueryAndFragment(const KURL& a, const KURL& b)
 {
-    int aLength = a.pathEnd();
-    int bLength = b.pathEnd();
-
-    if (aLength != bLength)
-        return false;
-
-    const String& aString = a.getString();
-    const String& bString = b.getString();
-    for (int i = 0; i < aLength; ++i) {
-        if (aString[i] != bString[i])
-            return false;
-    }
-    return true;
+    return StringView(a.getString(), 0, a.pathEnd()) == StringView(b.getString(), 0, b.pathEnd());
 }
 
 }  // namespace
 
 History::History(LocalFrame* frame)
     : DOMWindowProperty(frame)
     , m_lastStateObjectRequested(nullptr)
 {
 }
 
@@ skipping 147 matching lines @@
     if (!canChangeToUrl(fullURL, m_frame->document()->getSecurityOrigin(), m_frame->document()->url())) {
         // We can safely expose the URL to JavaScript, as a) no redirection takes place: JavaScript already had this URL, b) JavaScript can only access a same-origin History object.
         exceptionState.throwSecurityError("A history state object with URL '" + fullURL.elidedString() + "' cannot be created in a document with origin '" + m_frame->document()->getSecurityOrigin()->toString() + "' and URL '" + m_frame->document()->url().elidedString() + "'.");
         return;
     }
 
     m_frame->loader().updateForSameDocumentNavigation(fullURL, SameDocumentNavigationHistoryApi, data, restorationType, type, m_frame->document());
 }
 
 } // namespace blink