Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2303793002: Revert of [stubs] Port KeyedLoadIC_Generic stub to TurboFan (Closed)

Created:
4 years, 3 months ago by Jakob Kummerow
Modified:
4 years, 3 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, Igor Sheludko
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [stubs] Port KeyedLoadIC_Generic stub to TurboFan (patchset #4 id:60001 of https://codereview.chromium.org/2245683002/ ) Reason for revert: Suspected to cause webgl_conformance_tests failures: WebglConformance_conformance_textures_misc_tex_image_with_format_and_type (gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest) ... [21956:1299:0901/082859:INFO:CONSOLE(11)] "Uncaught TypeError: Cannot read property 'charCodeAt' of undefined", source: (11) [21956:1299:0901/082859:INFO:CONSOLE(174)] "Uncaught TypeError: Cannot read property 'charCodeAt' of undefined", source: http://127.0.0.1:56892/js/pnglib.js (174) Original issue's description: > [stubs] Port KeyedLoadIC_Generic stub to TurboFan > > And also handle dictionary elements loads in the dispatcher. > > Committed: https://crrev.com/fd5fe3b2a40cc7a9b044416798c3c2aa734469ff > Cr-Commit-Position: refs/heads/master@{#39070} TBR=verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/f93ee70c8812c2d0b5c420d82de8999bb81a6337 Cr-Commit-Position: refs/heads/master@{#39096}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -312 lines) Patch
M src/builtins/builtins.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/builtins/builtins-handler.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M src/builtins/builtins-sharedarraybuffer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/code-factory.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/code-stub-assembler.h View 2 chunks +5 lines, -13 lines 0 comments Download
M src/code-stub-assembler.cc View 8 chunks +71 lines, -268 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jakob Kummerow
Created Revert of [stubs] Port KeyedLoadIC_Generic stub to TurboFan
4 years, 3 months ago (2016-09-01 16:06:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2303793002/1
4 years, 3 months ago (2016-09-01 16:07:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 16:07:24 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f93ee70c8812c2d0b5c420d82de8999bb81a6337 Cr-Commit-Position: refs/heads/master@{#39096}
4 years, 3 months ago (2016-09-01 16:08:08 UTC) #7
Jakob Kummerow
4 years, 3 months ago (2016-09-05 12:09:02 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2313683002/ by jkummerow@chromium.org.

The reason for reverting is: Relanding with fix.

Powered by Google App Engine
This is Rietveld 408576698