src/builtins/builtins-sharedarraybuffer.cc - Issue 2303793002: Revert of [stubs] Port KeyedLoadIC_Generic stub to TurboFan

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins/builtins-sharedarraybuffer.cc

Issue 2303793002: Revert of [stubs] Port KeyedLoadIC_Generic stub to TurboFan (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/builtins/builtins-sharedarraybuffer.cc

diff --git a/src/builtins/builtins-sharedarraybuffer.cc b/src/builtins/builtins-sharedarraybuffer.cc

index cd9dc07e0c6eb8ca2561ab351123ccd959b91712..23d4f43af29f7c8de96fced22e2d39dce0ff8dee 100644

--- a/src/builtins/builtins-sharedarraybuffer.cc

+++ b/src/builtins/builtins-sharedarraybuffer.cc

@@ -141,7 +141,6 @@

using namespace compiler;

// Check if the index is in bounds. If not, throw RangeError.

CodeStubAssembler::Label if_inbounds(a), if_notinbounds(a);

- // TODO(jkummerow): Use unsigned comparison instead of "i<0 || i>length".

a->Branch(

a->WordOr(a->Int32LessThan(index_word, a->Int32Constant(0)),

a->Int32GreaterThanOrEqual(index_word, array_length_word)),

« no previous file with comments | « src/builtins/builtins-handler.cc ('k') | src/code-factory.cc » ('j') | no next file with comments »