third_party/WebKit/Source/core/paint/FilterPainter.cpp - Issue 2303703002: Revamp filter primitive region calculations for Filter Effects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/FilterPainter.cpp

Issue 2303703002: Revamp filter primitive region calculations for Filter Effects (Closed)

Patch Set: Baselines again; Manual for mac10.11-retina Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/FilterPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/FilterPainter.cpp b/third_party/WebKit/Source/core/paint/FilterPainter.cpp

index a291a134834d43af6737002b2063a853a11c5616..a563c24124f1b78490c0af1223f5baf83c1b9404 100644

--- a/third_party/WebKit/Source/core/paint/FilterPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/FilterPainter.cpp

@@ -34,7 +34,7 @@ FilterPainter::FilterPainter(PaintLayer& layer, GraphicsContext& context, const

DCHECK(layer.filterInfo());

- lastEffect->determineFilterPrimitiveSubregion(MapRectForward);

+ lastEffect->determineMaximumEffectRect(MapRectForward);

sk_sp<SkImageFilter> imageFilter = SkiaImageFilterBuilder::build(lastEffect, ColorSpaceDeviceRGB);

if (!imageFilter)

return;