third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp - Issue 2303703002: Revamp filter primitive region calculations for Filter Effects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp

Issue 2303703002: Revamp filter primitive region calculations for Filter Effects (Closed)

Patch Set: Baselines again; Manual for mac10.11-retina Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp b/third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp

index fbaae58c59111fdf85a3d8403848de748678b4fe..5f2a8384db38e90aa496d92e3e7bdb89ed141115 100644

--- a/third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp

@@ -95,7 +95,7 @@ GraphicsContext* SVGFilterPainter::prepareEffect(const LayoutObject& object, SVG

IntRect sourceRegion = enclosingIntRect(intersection(filter->filterRegion(), object.strokeBoundingBox()));

filter->getSourceGraphic()->setSourceRect(sourceRegion);

- filter->lastEffect()->determineFilterPrimitiveSubregion(ClipToFilterRegion);

+ filter->lastEffect()->determineMaximumEffectRect(ClipToFilterRegion);

FilterData* filterData = FilterData::create();

filterData->filter = filter;