Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1318)

Unified Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Issue 2303613003: WebRange-ify WebWidget::applyReplacementRange. (Closed)
Patch Set: Updated comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebFrameWidgetImpl.h ('k') | third_party/WebKit/Source/web/WebViewImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
index 86c93cfd5d6b182744b968eb9c2cdc3f249a90ae..530b89b36aebc95ba6c1f4fbc1a12c53eee95068 100644
--- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
+++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
@@ -879,12 +879,12 @@ bool WebFrameWidgetImpl::getCompositionCharacterBounds(WebVector<WebRect>& bound
return true;
}
-void WebFrameWidgetImpl::applyReplacementRange(int start, int length)
+void WebFrameWidgetImpl::applyReplacementRange(const WebRange& range)
esprehn 2016/09/02 21:25:22 fwiw WebRange is just a wrapper around some ints,
{
if (LocalFrame* frame = focusedLocalFrameInWidget()) {
// TODO(dglazkov): Going from LocalFrame to WebLocalFrameImpl seems
// silly. What is going on here?
- WebLocalFrameImpl::fromFrame(frame)->selectRange(WebRange(start, length));
+ WebLocalFrameImpl::fromFrame(frame)->selectRange(range);
}
}
« no previous file with comments | « third_party/WebKit/Source/web/WebFrameWidgetImpl.h ('k') | third_party/WebKit/Source/web/WebViewImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698