WebRange-ify WebWidget::applyReplacementRange.

third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 861 matching lines @@
         if (!webLocalFrame->firstRectForCharacterRange(offset + i, 1, webrect)) {
             DLOG(ERROR) << "Could not retrieve character rectangle at " << i;
             return false;
         }
         result[i] = webrect;
     }
     bounds.swap(result);
     return true;
 }
 
-void WebFrameWidgetImpl::applyReplacementRange(int start, int length)
+void WebFrameWidgetImpl::applyReplacementRange(const WebRange& range)

[esprehn, 2016/09/02 21:25:22]

fwiw WebRange is just a wrapper around some ints, so passing it by value is
probably fine, and might be faster than the reference I think?

Either is okay though, this code is not performance sensitive

 {
     if (LocalFrame* frame = focusedLocalFrameInWidget()) {
         // TODO(dglazkov): Going from LocalFrame to WebLocalFrameImpl seems
         // silly. What is going on here?
-        WebLocalFrameImpl::fromFrame(frame)->selectRange(WebRange(start, length));
+        WebLocalFrameImpl::fromFrame(frame)->selectRange(range);
     }
 }
 
 void WebFrameWidgetImpl::handleMouseLeave(LocalFrame& mainFrame, const WebMouseEvent& event)
 {
     // FIXME: WebWidget doesn't have the method below.
     // m_client->setMouseOverURL(WebURL());
     PageWidgetEventHandler::handleMouseLeave(mainFrame, event);
 }
 
@@ skipping 540 matching lines @@
 }
 
 LocalFrame* WebFrameWidgetImpl::focusedLocalFrameAvailableForIme() const
 {
     if (!m_imeAcceptEvents)
         return nullptr;
     return focusedLocalFrameInWidget();
 }
 
 } // namespace blink