WebRange-ify WebWidget::applyReplacementRange.

WebRange-ify WebWidget::applyReplacementRange.

No functional changes, just removing using pairs of ints.

R=esprehn
BUG=

Committed: https://crrev.com/0d680e30bb65a3c6a82abb073ea6c26f0056e885
Cr-Commit-Position: refs/heads/master@{#416349}

[dglazkov, 2016-09-02 03:03:09]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 03:03:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dglazkov, 2016-09-02 03:17:57]

PTAL

[dglazkov, 2016-09-02 03:50:30]

Updated comments.

[dglazkov, 2016-09-02 03:50:33]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 03:50:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 05:10:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 05:10:26]

Dry run: This issue passed the CQ dry run.

[esprehn, 2016-09-02 21:25:22]

lgtm

https://codereview.chromium.org/2303613003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp (right):

https://codereview.chromium.org/2303613003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp:882: void
WebFrameWidgetImpl::applyReplacementRange(const WebRange& range)
fwiw WebRange is just a wrapper around some ints, so passing it by value is
probably fine, and might be faster than the reference I think?

Either is okay though, this code is not performance sensitive

[dglazkov, 2016-09-02 21:29:17]

On 2016/09/02 at 21:25:22, esprehn wrote:
> lgtm
> 
>
https://codereview.chromium.org/2303613003/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp (right):
> 
>
https://codereview.chromium.org/2303613003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp:882: void
WebFrameWidgetImpl::applyReplacementRange(const WebRange& range)
> fwiw WebRange is just a wrapper around some ints, so passing it by value is
probably fine, and might be faster than the reference I think?
> 
> Either is okay though, this code is not performance sensitive

SGTM, I can change in follow-up patch.

[dglazkov, 2016-09-02 21:29:21]

The CQ bit was checked by dglazkov@chromium.org

[commit-bot: I haz the power, 2016-09-02 21:29:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 21:34:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-02 21:35:47]

Description was changed from

==========
WebRange-ify WebWidget::applyReplacementRange.

No functional changes, just removing using pairs of ints.

R=esprehn
BUG=
==========

to

==========
WebRange-ify WebWidget::applyReplacementRange.

No functional changes, just removing using pairs of ints.

R=esprehn
BUG=

Committed: https://crrev.com/0d680e30bb65a3c6a82abb073ea6c26f0056e885
Cr-Commit-Position: refs/heads/master@{#416349}
==========

[commit-bot: I haz the power, 2016-09-02 21:35:48]

Patchset 2 (id:??) landed as
https://crrev.com/0d680e30bb65a3c6a82abb073ea6c26f0056e885
Cr-Commit-Position: refs/heads/master@{#416349}