Make CPDF_GeneralState have a CPDF_GeneralStateData

Make CPDF_GeneralState have a CPDF_GeneralStateData

Remove a const cast along the way and propagate to callers.

Committed: https://pdfium.googlesource.com/pdfium/+/bbee445c5a77dfbaea9041308f001c756e49c5fd

[Tom Sepez, 2016-08-31 23:52:48]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 23:52:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-08-31 23:54:32]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 23:54:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-08-31 23:55:32]

Description was changed from

==========
Make CPDF_GeneralState have a CPDF_GeneralStateData

BUG=
==========

to

==========
Make CPDF_GeneralState have a CPDF_GeneralStateData

Remove a const cast along the way and propagate to callers.
==========

[commit-bot: I haz the power, 2016-08-31 23:57:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 23:57:24]

Dry run: Try jobs failed on following builders:
  mac on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/mac/builds/1884)

[Tom Sepez, 2016-09-01 00:01:01]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 00:01:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 00:06:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 00:06:19]

Dry run: Try jobs failed on following builders:
  linux_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa/build...)

[Tom Sepez, 2016-09-01 00:13:08]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 00:13:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 00:32:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 00:32:04]

Dry run: Try jobs failed on following builders:
  mac on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/mac/builds/1888)

[Tom Sepez, 2016-09-01 16:34:35]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 16:34:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 16:42:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 16:42:38]

Dry run: Try jobs failed on following builders:
  linux_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa/build...)
  win on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win/builds/1906)
  win_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa/builds/...)

[Tom Sepez, 2016-09-01 16:56:34]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 16:56:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 17:00:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 17:00:50]

Dry run: Try jobs failed on following builders:
  win_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa/builds/...)

[Tom Sepez, 2016-09-01 17:42:19]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 17:42:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 18:13:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 18:13:13]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-09-01 18:23:41]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 18:23:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-09-01 18:24:03]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 18:24:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-09-01 19:07:47]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 19:07:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-09-01 19:26:45]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 19:26:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-09-01 19:27:29]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-09-01 19:27:30]

Dan, for review (I sent the follow-up before landing this somehow).

[dsinclair, 2016-09-01 19:35:52]

https://codereview.chromium.org/2303553002/diff/160001/core/fpdfapi/fpdf_rend...
File core/fpdfapi/fpdf_render/fpdf_render_pattern.cpp (right):

https://codereview.chromium.org/2303553002/diff/160001/core/fpdfapi/fpdf_rend...
core/fpdfapi/fpdf_render/fpdf_render_pattern.cpp:965: FXSYS_round(255 * (bStroke
? pPageObj->m_GeneralState.GetStrokeAlpha()
Why does this and the below change?

[Tom Sepez, 2016-09-01 20:01:48]

https://codereview.chromium.org/2303553002/diff/160001/core/fpdfapi/fpdf_rend...
File core/fpdfapi/fpdf_render/fpdf_render_pattern.cpp (right):

https://codereview.chromium.org/2303553002/diff/160001/core/fpdfapi/fpdf_rend...
core/fpdfapi/fpdf_render/fpdf_render_pattern.cpp:965: FXSYS_round(255 * (bStroke
? pPageObj->m_GeneralState.GetStrokeAlpha()
On 2016/09/01 19:35:52, dsinclair wrote:
> Why does this and the below change?

They are inconsistent about whether the API to the GeneralState is in terms of
floats 0.0..0.1 or ints 0..255.  This just makes the General State always be in
terms of 0.0..0.1, at the risk of some duplicate conversions by the callers.

[Tom Sepez, 2016-09-01 20:09:01]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 20:09:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 20:26:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 20:26:17]

Dry run: Try jobs failed on following builders:
  win_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_no_v8/build...)

[Tom Sepez, 2016-09-01 20:30:31]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 20:30:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 20:42:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 20:42:38]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-09-02 20:21:57]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-09-02 20:22:14]

Lei, since Dan is gone on Fridays ...

[Lei Zhang, 2016-09-02 21:44:56]

On 2016/09/02 20:22:14, Tom Sepez wrote:
> Lei, since Dan is gone on Fridays ...

Looking. I need to follow Dan's example. ;-)

[Lei Zhang, 2016-09-02 22:00:43]

lgtm

https://codereview.chromium.org/2303553002/diff/200001/core/fpdfapi/fpdf_page...
File core/fpdfapi/fpdf_page/cpdf_allstates.cpp (right):

https://codereview.chromium.org/2303553002/diff/200001/core/fpdfapi/fpdf_page...
core/fpdfapi/fpdf_page/cpdf_allstates.cpp:120:
FXSYS_memcpy(m_GeneralState.GetMutableSMaskMatrix(),
Do you know why |m_SMaskMatrix| isn't just a CFX_Matrix?

https://codereview.chromium.org/2303553002/diff/200001/core/fpdfapi/fpdf_rend...
File core/fpdfapi/fpdf_render/fpdf_render.cpp (right):

https://codereview.chromium.org/2303553002/diff/200001/core/fpdfapi/fpdf_rend...
core/fpdfapi/fpdf_render/fpdf_render.cpp:527: int32_t alpha =
(int32_t)(pObj->m_GeneralState.GetFillAlpha() * 255);
Get rid of C-style casts here and below.

https://codereview.chromium.org/2303553002/diff/200001/core/fpdfapi/fpdf_rend...
core/fpdfapi/fpdf_render/fpdf_render.cpp:807: FXSYS_memcpy(&smask_matrix,
pPageObj->m_GeneralState.GetSMaskMatrix(),
The only other |m_SMaskMatrix| usage.

[Tom Sepez, 2016-09-02 22:09:57]

https://codereview.chromium.org/2303553002/diff/200001/core/fpdfapi/fpdf_page...
File core/fpdfapi/fpdf_page/cpdf_allstates.cpp (right):

https://codereview.chromium.org/2303553002/diff/200001/core/fpdfapi/fpdf_page...
core/fpdfapi/fpdf_page/cpdf_allstates.cpp:120:
FXSYS_memcpy(m_GeneralState.GetMutableSMaskMatrix(),
On 2016/09/02 22:00:43, Lei Zhang wrote:
> Do you know why |m_SMaskMatrix| isn't just a CFX_Matrix?

Beats me.

https://codereview.chromium.org/2303553002/diff/200001/core/fpdfapi/fpdf_rend...
File core/fpdfapi/fpdf_render/fpdf_render.cpp (right):

https://codereview.chromium.org/2303553002/diff/200001/core/fpdfapi/fpdf_rend...
core/fpdfapi/fpdf_render/fpdf_render.cpp:527: int32_t alpha =
(int32_t)(pObj->m_GeneralState.GetFillAlpha() * 255);
On 2016/09/02 22:00:43, Lei Zhang wrote:
> Get rid of C-style casts here and below.

Done.

https://codereview.chromium.org/2303553002/diff/200001/core/fpdfapi/fpdf_rend...
core/fpdfapi/fpdf_render/fpdf_render.cpp:807: FXSYS_memcpy(&smask_matrix,
pPageObj->m_GeneralState.GetSMaskMatrix(),
On 2016/09/02 22:00:43, Lei Zhang wrote:
> The only other |m_SMaskMatrix| usage.

Ok, I've got a follow-up started already where I've made some changes to the
'Data itself.  I'll do that there.

[Tom Sepez, 2016-09-02 22:10:59]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-09-02 22:11:00]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2303553002/#ps240001
(title: "Nit")

[commit-bot: I haz the power, 2016-09-02 22:11:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 22:22:03]

Description was changed from

==========
Make CPDF_GeneralState have a CPDF_GeneralStateData

Remove a const cast along the way and propagate to callers.
==========

to

==========
Make CPDF_GeneralState have a CPDF_GeneralStateData

Remove a const cast along the way and propagate to callers.

Committed:
https://pdfium.googlesource.com/pdfium/+/bbee445c5a77dfbaea9041308f001c756e49...
==========

[commit-bot: I haz the power, 2016-09-02 22:22:04]

Committed patchset #13 (id:240001) as
https://pdfium.googlesource.com/pdfium/+/bbee445c5a77dfbaea9041308f001c756e49...