Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 2303533004: Revert of [api] Add interceptor for defineProperty(). (Closed)

Created:
4 years, 3 months ago by Jakob Kummerow
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@DefineProperty
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [api] Add interceptor for defineProperty(). (patchset #9 id:160001 of https://codereview.chromium.org/2272383002/ ) Reason for revert: Breaks cctest/test-api-interceptors/QueryInterceptor on the waterfall Original issue's description: > [api] Add interceptor for defineProperty(). > > With the Indexed/GenericNamedPropertyDefinerCallback it is possible to intercept Object.defineProperty() calls. > > Requests that call JSReceiver::OrdinaryDefineOwnProperty() internally, also trigger the interceptor. This includes Object.freeze(), Object.preventExtensions(), and Object.seal(). > > BUG= > > Committed: https://crrev.com/b9d985975cf3bab0ded0cec9fafd3799f9bde29a > Cr-Commit-Position: refs/heads/master@{#39094} TBR=jochen@chromium.org,franzih@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/9fe4efe5b8f0af6b8cab2a527a3f4fa029d46d69 Cr-Commit-Position: refs/heads/master@{#39095}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -678 lines) Patch
M include/v8.h View 6 chunks +0 lines, -65 lines 0 comments Download
M src/api.cc View 5 chunks +18 lines, -16 lines 0 comments Download
M src/api-arguments.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/api-arguments-inl.h View 2 chunks +0 lines, -35 lines 0 comments Download
M src/counters.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/objects.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/objects.cc View 2 chunks +0 lines, -94 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-api-interceptors.cc View 4 chunks +2 lines, -455 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jakob Kummerow
Created Revert of [api] Add interceptor for defineProperty().
4 years, 3 months ago (2016-09-01 16:03:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2303533004/1
4 years, 3 months ago (2016-09-01 16:03:27 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 16:03:43 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 16:04:11 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fe4efe5b8f0af6b8cab2a527a3f4fa029d46d69
Cr-Commit-Position: refs/heads/master@{#39095}

Powered by Google App Engine
This is Rietveld 408576698