Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: include/v8.h

Issue 2303533004: Revert of [api] Add interceptor for defineProperty(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@DefineProperty
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index c3698c3fcf46a6f4acbb0d2b37e3f4683b706927..5f67a087ac737c5137bc9a551e9c79ee3cd8bc50 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -4672,29 +4672,6 @@
typedef void (*GenericNamedPropertyEnumeratorCallback)(
const PropertyCallbackInfo<Array>& info);
-/**
- * Interceptor for defineProperty requests on an object.
- *
- * Use `info.GetReturnValue()` to indicate whether the request was intercepted
- * or not. If the definer successfully intercepts the request, i.e., if the
- * request should not be further executed, call
- * `info.GetReturnValue().Set(value)`. If the definer
- * did not intercept the request, i.e., if the request should be handled as
- * if no interceptor is present, do not not call `Set()`.
- *
- * \param property The name of the property for which the request was
- * intercepted.
- * \param desc The property descriptor which is used to define the
- * property if the request is not intercepted.
- * \param info Information about the intercepted request, such as
- * isolate, receiver, return value, or whether running in `'use strict'` mode.
- * See `PropertyCallbackInfo`.
- *
- * See also `ObjectTemplate::SetNamedPropertyHandler`.
- */
-typedef void (*GenericNamedPropertyDefinerCallback)(
- Local<Name> key, const PropertyDescriptor& desc,
- const PropertyCallbackInfo<Value>& info);
/**
* Returns the value of the property if the getter intercepts the
@@ -4741,9 +4718,6 @@
typedef void (*IndexedPropertyEnumeratorCallback)(
const PropertyCallbackInfo<Array>& info);
-typedef void (*IndexedPropertyDefinerCallback)(
- uint32_t index, const PropertyDescriptor& desc,
- const PropertyCallbackInfo<Value>& info);
/**
* Access type specification.
@@ -5006,25 +4980,6 @@
query(query),
deleter(deleter),
enumerator(enumerator),
- definer(0),
- data(data),
- flags(flags) {}
-
- NamedPropertyHandlerConfiguration(
- GenericNamedPropertyGetterCallback getter,
- GenericNamedPropertySetterCallback setter,
- GenericNamedPropertyQueryCallback query,
- GenericNamedPropertyDeleterCallback deleter,
- GenericNamedPropertyEnumeratorCallback enumerator,
- GenericNamedPropertyDefinerCallback definer,
- Local<Value> data = Local<Value>(),
- PropertyHandlerFlags flags = PropertyHandlerFlags::kNone)
- : getter(getter),
- setter(setter),
- query(query),
- deleter(deleter),
- enumerator(enumerator),
- definer(definer),
data(data),
flags(flags) {}
@@ -5033,7 +4988,6 @@
GenericNamedPropertyQueryCallback query;
GenericNamedPropertyDeleterCallback deleter;
GenericNamedPropertyEnumeratorCallback enumerator;
- GenericNamedPropertyDefinerCallback definer;
Local<Value> data;
PropertyHandlerFlags flags;
};
@@ -5054,24 +5008,6 @@
query(query),
deleter(deleter),
enumerator(enumerator),
- definer(0),
- data(data),
- flags(flags) {}
-
- IndexedPropertyHandlerConfiguration(
- IndexedPropertyGetterCallback getter,
- IndexedPropertySetterCallback setter, IndexedPropertyQueryCallback query,
- IndexedPropertyDeleterCallback deleter,
- IndexedPropertyEnumeratorCallback enumerator,
- IndexedPropertyDefinerCallback definer,
- Local<Value> data = Local<Value>(),
- PropertyHandlerFlags flags = PropertyHandlerFlags::kNone)
- : getter(getter),
- setter(setter),
- query(query),
- deleter(deleter),
- enumerator(enumerator),
- definer(definer),
data(data),
flags(flags) {}
@@ -5080,7 +5016,6 @@
IndexedPropertyQueryCallback query;
IndexedPropertyDeleterCallback deleter;
IndexedPropertyEnumeratorCallback enumerator;
- IndexedPropertyDefinerCallback definer;
Local<Value> data;
PropertyHandlerFlags flags;
};
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698