Tracing v2: wire up stubs generated by the protozero protoc plugin

Tracing v2: wire up stubs generated by the protozero protoc plugin

The previous CLs faked the auto-generated Event class.
This is because the protoc protozero plugin was not ready.
Fixing the glitch now that the protobuf compiler support is
ready.

BUG=608719
Committed: https://crrev.com/79f65ab752df8c192752b1d1f46094518353c6d1
Cr-Commit-Position: refs/heads/master@{#416530}

[Primiano Tucci (use gerrit), 2016-09-02 15:15:33]

The CQ bit was checked by primiano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 15:15:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Primiano Tucci (use gerrit), 2016-09-02 15:15:51]

primiano@chromium.org changed reviewers:
+ kraynov@chromium.org, oysteine@chromium.org

[commit-bot: I haz the power, 2016-09-02 15:19:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 15:19:14]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kraynov, 2016-09-02 16:09:00]

lgtm

[Primiano Tucci (use gerrit), 2016-09-05 08:12:25]

The CQ bit was checked by primiano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-05 08:12:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[petrcermak, 2016-09-05 08:47:59]

petrcermak@chromium.org changed reviewers:
+ petrcermak@chromium.org

[petrcermak, 2016-09-05 08:48:00]

LGTM with 3 code nits and one description nits: s/did fake/faked/.

Thanks,
Petr

https://codereview.chromium.org/2303353002/diff/20001/components/tracing/prot...
File components/tracing/proto/event.proto (right):

https://codereview.chromium.org/2303353002/diff/20001/components/tracing/prot...
components/tracing/proto/event.proto:12: // used fields fields (to save trace
size). Use the range 16+ for fields that
nit: s/fields fields/fields/

https://codereview.chromium.org/2303353002/diff/20001/components/tracing/prot...
components/tracing/proto/event.proto:15: enum EventType {
One would expect these to be sorted in an increasing order in value (77 < 88).
Not sure if protos forbid multiple enum values with the same name. If so, it's
going to be difficult to verify that there are no overlaps in the future (when
there are lots of event types).

https://codereview.chromium.org/2303353002/diff/20001/components/tracing/prot...
components/tracing/proto/event.proto:16: COMPLETE = 88;  // = 'X'
nit: add period at the end of comment? (not sure what the proto code style is)

https://codereview.chromium.org/2303353002/diff/20001/components/tracing/prot...
components/tracing/proto/event.proto:17: METADATA = 77;  // = 'M'
ditto

[commit-bot: I haz the power, 2016-09-05 09:15:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-05 09:16:00]

Dry run: This issue passed the CQ dry run.

[Primiano Tucci (use gerrit), 2016-09-05 09:37:44]

https://codereview.chromium.org/2303353002/diff/20001/components/tracing/prot...
File components/tracing/proto/event.proto (right):

https://codereview.chromium.org/2303353002/diff/20001/components/tracing/prot...
components/tracing/proto/event.proto:12: // used fields fields (to save trace
size). Use the range 16+ for fields that
On 2016/09/05 08:48:00, petrcermak wrote:
> nit: s/fields fields/fields/

Done.

https://codereview.chromium.org/2303353002/diff/20001/components/tracing/prot...
components/tracing/proto/event.proto:15: enum EventType {
On 2016/09/05 08:48:00, petrcermak wrote:
> One would expect these to be sorted in an increasing order in value (77 < 88).
Done.

> Not sure if protos forbid multiple enum values with the same name. If so, it's
> going to be difficult to verify that there are no overlaps in the future (when
> there are lots of event types).
Ah good point. I can ask kraynov to add a check to its generator.

https://codereview.chromium.org/2303353002/diff/20001/components/tracing/prot...
components/tracing/proto/event.proto:16: COMPLETE = 88;  // = 'X'
On 2016/09/05 08:48:00, petrcermak wrote:
> nit: add period at the end of comment? (not sure what the proto code style is)

Done.

https://codereview.chromium.org/2303353002/diff/20001/components/tracing/prot...
components/tracing/proto/event.proto:17: METADATA = 77;  // = 'M'
On 2016/09/05 08:48:00, petrcermak wrote:
> ditto

Done.

[Primiano Tucci (use gerrit), 2016-09-05 09:37:48]

The CQ bit was checked by primiano@chromium.org

[Primiano Tucci (use gerrit), 2016-09-05 09:37:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
kraynov@chromium.org, petrcermak@chromium.org
Link to the patchset: https://codereview.chromium.org/2303353002/#ps40001
(title: "petrcermak review")

[commit-bot: I haz the power, 2016-09-05 09:37:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Primiano Tucci (use gerrit), 2016-09-05 11:20:48]

Description was changed from

==========
Tracing v2: wire up stubs generated by the protozero protoc plugin

The previous CLs did fake the auto-generated Event class.
This is because the protoc protozero plugin was not ready.
Fixing the glitch now that the protobuf compiler support is
ready.

BUG=608719
==========

to

==========
Tracing v2: wire up stubs generated by the protozero protoc plugin

The previous CLs faked the auto-generated Event class.
This is because the protoc protozero plugin was not ready.
Fixing the glitch now that the protobuf compiler support is
ready.

BUG=608719
==========

[commit-bot: I haz the power, 2016-09-05 11:40:12]

Description was changed from

==========
Tracing v2: wire up stubs generated by the protozero protoc plugin

The previous CLs faked the auto-generated Event class.
This is because the protoc protozero plugin was not ready.
Fixing the glitch now that the protobuf compiler support is
ready.

BUG=608719
==========

to

==========
Tracing v2: wire up stubs generated by the protozero protoc plugin

The previous CLs faked the auto-generated Event class.
This is because the protoc protozero plugin was not ready.
Fixing the glitch now that the protobuf compiler support is
ready.

BUG=608719
==========

[commit-bot: I haz the power, 2016-09-05 11:40:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-05 11:42:01]

Description was changed from

==========
Tracing v2: wire up stubs generated by the protozero protoc plugin

The previous CLs faked the auto-generated Event class.
This is because the protoc protozero plugin was not ready.
Fixing the glitch now that the protobuf compiler support is
ready.

BUG=608719
==========

to

==========
Tracing v2: wire up stubs generated by the protozero protoc plugin

The previous CLs faked the auto-generated Event class.
This is because the protoc protozero plugin was not ready.
Fixing the glitch now that the protobuf compiler support is
ready.

BUG=608719

Committed: https://crrev.com/79f65ab752df8c192752b1d1f46094518353c6d1
Cr-Commit-Position: refs/heads/master@{#416530}
==========

[commit-bot: I haz the power, 2016-09-05 11:42:03]

Patchset 3 (id:??) landed as
https://crrev.com/79f65ab752df8c192752b1d1f46094518353c6d1
Cr-Commit-Position: refs/heads/master@{#416530}