Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Side by Side Diff: components/tracing/proto/event.proto

Issue 2303353002: Tracing v2: wire up stubs generated by the protozero protoc plugin (Closed)
Patch Set: DEPS Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/tracing/proto/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 syntax = "proto2"; 5 syntax = "proto2";
6 option optimize_for = LITE_RUNTIME; 6 option optimize_for = LITE_RUNTIME;
7 7
8 package tracing.proto; 8 package tracing.proto;
9 9
10 // Note on field numbers: fields in the range [1, 15] can be encoded using a
11 // single byte preamble. Hence they should be used only for the most commonly
12 // used fields fields (to save trace size). Use the range 16+ for fields that
petrcermak 2016/09/05 08:48:00 nit: s/fields fields/fields/
Primiano Tucci (use gerrit) 2016/09/05 09:37:44 Done.
13 // are not expected to be used frequently.
10 message Event { 14 message Event {
11 // TODO(kraynov): Make proto definitions. 15 enum EventType {
petrcermak 2016/09/05 08:48:00 One would expect these to be sorted in an increasi
Primiano Tucci (use gerrit) 2016/09/05 09:37:44 Done.
16 COMPLETE = 88; // = 'X'
petrcermak 2016/09/05 08:48:00 nit: add period at the end of comment? (not sure w
Primiano Tucci (use gerrit) 2016/09/05 09:37:44 Done.
17 METADATA = 77; // = 'M'
petrcermak 2016/09/05 08:48:00 ditto
Primiano Tucci (use gerrit) 2016/09/05 09:37:44 Done.
18 };
19
20 optional EventType type = 1;
21
22 oneof name {
23 int64 name_id = 2;
24 string name_str = 16;
25 }
26
27 optional int64 category_id = 4;
28
29 optional uint64 timestamp = 5;
30 optional uint64 thread_timestamp = 6;
31
32 // TODO(primiano,kraynov): Add args and further fields in next CLs.
12 } 33 }
OLDNEW
« no previous file with comments | « components/tracing/proto/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698