Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2303333002: Revert of Add step to show goma stat in goma module (Closed)

Created:
4 years, 3 months ago by tandrii(chromium)
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Add step to show goma stat in goma module (patchset #1 id:1 of https://codereview.chromium.org/2300933002/ ) Reason for revert: I think this broke internal builders (see http://crbug.com/643640). BUG=643640 Original issue's description: > Add step to show goma stat in goma module > > BUG=544330 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/a74f612ef99de4de59320e5f390e16bf6934cf88 TBR=phajdan.jr@chromium.org,shinyak@chromium.org,ukai@chromium.org,yyanagisawa@chromium.org,tikuta@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=544330 Committed: https://chromium.googlesource.com/chromium/tools/build/+/a13d2ccffdaef849e672f47ceba21d30045c19ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -81 lines) Patch
M scripts/slave/recipe_modules/goma/api.py View 1 chunk +0 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/goma/example.expected/linux.json View 1 chunk +0 lines, -12 lines 0 comments Download
M scripts/slave/recipe_modules/goma/example.expected/linux_upload_logs.json View 1 chunk +0 lines, -14 lines 0 comments Download
M scripts/slave/recipe_modules/goma/example.expected/mac.json View 1 chunk +0 lines, -12 lines 0 comments Download
M scripts/slave/recipe_modules/goma/example.expected/mac_upload_logs.json View 1 chunk +0 lines, -14 lines 0 comments Download
M scripts/slave/recipe_modules/goma/example.expected/win.json View 1 chunk +0 lines, -12 lines 0 comments Download
M scripts/slave/recipe_modules/goma/example.expected/win_upload_logs.json View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
tandrii(chromium)
Created Revert of Add step to show goma stat in goma module
4 years, 3 months ago (2016-09-02 14:56:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2303333002/1
4 years, 3 months ago (2016-09-02 14:56:23 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 14:56:31 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/a13d2ccffdaef849e672...

Powered by Google App Engine
This is Rietveld 408576698