Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: scripts/slave/recipe_modules/goma/api.py

Issue 2303333002: Revert of Add step to show goma stat in goma module (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/goma/example.expected/linux.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from recipe_engine import recipe_api 5 from recipe_engine import recipe_api
6 6
7 class GomaApi(recipe_api.RecipeApi): 7 class GomaApi(recipe_api.RecipeApi):
8 """GomaApi contains helper functions for using goma.""" 8 """GomaApi contains helper functions for using goma."""
9 9
10 def __init__(self, **kwargs): 10 def __init__(self, **kwargs):
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 StepFailure if it fails to stop goma or upload logs. 178 StepFailure if it fails to stop goma or upload logs.
179 """ 179 """
180 180
181 assert self._goma_dir 181 assert self._goma_dir
182 assert self._goma_started 182 assert self._goma_started
183 183
184 with self.m.step.defer_results(): 184 with self.m.step.defer_results():
185 self.m.python(name='goma_jsonstatus', script=self.goma_ctl, 185 self.m.python(name='goma_jsonstatus', script=self.goma_ctl,
186 args=['jsonstatus', self.json_path], 186 args=['jsonstatus', self.json_path],
187 env=self._goma_ctl_env, **kwargs) 187 env=self._goma_ctl_env, **kwargs)
188 self.m.python(name='goma_stat', script=self.goma_ctl,
189 args=['stat'],
190 env=self._goma_ctl_env, **kwargs)
191 self.m.python(name='stop_goma', script=self.goma_ctl, 188 self.m.python(name='stop_goma', script=self.goma_ctl,
192 args=['stop'], env=self._goma_ctl_env, **kwargs) 189 args=['stop'], env=self._goma_ctl_env, **kwargs)
193 self._upload_logs(ninja_log_outdir, ninja_log_compiler, 190 self._upload_logs(ninja_log_outdir, ninja_log_compiler,
194 ninja_log_command, ninja_log_exit_status) 191 ninja_log_command, ninja_log_exit_status)
195 self._stop_cloudtail() 192 self._stop_cloudtail()
196 193
197 self._goma_started = False 194 self._goma_started = False
198 self._goma_ctl_env = {} 195 self._goma_ctl_env = {}
199 196
200 def _upload_logs(self, ninja_log_outdir=None, ninja_log_compiler=None, 197 def _upload_logs(self, ninja_log_outdir=None, ninja_log_compiler=None,
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 ]) 237 ])
241 238
242 239
243 self.m.python( 240 self.m.python(
244 name=name or 'upload_log', 241 name=name or 'upload_log',
245 script=self.package_repo_resource( 242 script=self.package_repo_resource(
246 'scripts', 'slave', 'upload_goma_logs.py'), 243 'scripts', 'slave', 'upload_goma_logs.py'),
247 args=args, 244 args=args,
248 env=self._goma_ctl_env 245 env=self._goma_ctl_env
249 ) 246 )
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/goma/example.expected/linux.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698