|
|
Created:
7 years, 4 months ago by Dan Beam Modified:
7 years ago CC:
chromium-reviews, cmp-cc_chromium.org Visibility:
Public. |
DescriptionFix double commenting that has made "-->" appear on the console FOREVER.
R=hinoka@google.com, hinoka@chromium.org
BUG=none
TEST=no "-->" on build page
NOTRY=true
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234985
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #Patch Set 4 : #Messages
Total messages: 14 (0 generated)
hinoka@: ping, also is there expected test HTML I need to update now? tools_presubmit doesn't seem to run and gcl presubmit doesn't seem to pick up that I have installed the appengine SDK and added it to $PYTHONPATH.
Hm I've never noticed that. LGTM. There are instructions in presubmit to set up how tests run, though if you just run it through the CQ, the CQ should just be able to run the tests.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/23033018/6001
Presubmit check for 23033018-6001 failed and returned exit status 1. Running presubmit commit checks ... ** Presubmit ERRORS ** nosetests failed! Command nosetests --with-gae --gae-lib-root=/b/google_appengine returned non-zero exit status 1 Traceback (most recent call last): File "/usr/local/bin/nosetests", line 5, in <module> from pkg_resources import load_entry_point File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 2707, in <module> working_set.require(__requires__) File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 686, in require needed = self.resolve(parse_requirements(requirements)) File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 584, in resolve raise DistributionNotFound(req) pkg_resources.DistributionNotFound: nose==1.1.2 Pylint (9 files) failed ************* Module app_test F0401: 73,4:MainTestCase.test_main_page_redirect: Unable to import 'webtest' F0401: 93,4:AppTestCase.test_app: Unable to import 'webtest' F0401:104,4:AppTestCase.test_app_blob: Unable to import 'webtest' F0401:115,4:AppTestCase.test_app_unicode: Unable to import 'webtest' F0401:127,4:AppTestCase.test_app_unicode_blob: Unable to import 'webtest' F0401:140,4:AppTestCase.test_app_cp1252: Unable to import 'webtest' F0401:152,4:AppTestCase.test_app_cp1252_blob: Unable to import 'webtest' F0401:166,4:AppTestCase.test_app_bogus_query_string: Unable to import 'webtest' F0401:167,4:AppTestCase.test_app_bogus_query_string: Unable to import 'webtest' Presubmit checks took 8.3s to calculate.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/23033018/6001
Presubmit check for 23033018-6001 failed and returned exit status 1. Running presubmit commit checks ... ** Presubmit ERRORS ** nosetests failed! Command nosetests --with-gae --gae-lib-root=/b/google_appengine returned non-zero exit status 1 Traceback (most recent call last): File "/usr/local/bin/nosetests", line 5, in <module> from pkg_resources import load_entry_point File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 2707, in <module> working_set.require(__requires__) File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 686, in require needed = self.resolve(parse_requirements(requirements)) File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 584, in resolve raise DistributionNotFound(req) pkg_resources.DistributionNotFound: nose==1.1.2 Pylint (9 files) failed ************* Module app_test F0401: 73,4:MainTestCase.test_main_page_redirect: Unable to import 'webtest' F0401: 93,4:AppTestCase.test_app: Unable to import 'webtest' F0401:104,4:AppTestCase.test_app_blob: Unable to import 'webtest' F0401:115,4:AppTestCase.test_app_unicode: Unable to import 'webtest' F0401:127,4:AppTestCase.test_app_unicode_blob: Unable to import 'webtest' F0401:140,4:AppTestCase.test_app_cp1252: Unable to import 'webtest' F0401:152,4:AppTestCase.test_app_cp1252_blob: Unable to import 'webtest' F0401:166,4:AppTestCase.test_app_bogus_query_string: Unable to import 'webtest' F0401:167,4:AppTestCase.test_app_bogus_query_string: Unable to import 'webtest' Presubmit checks took 6.4s to calculate.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/23033018/6001
Presubmit check for 23033018-6001 failed and returned exit status 1. Running presubmit commit checks ... ** Presubmit ERRORS ** nosetests failed! Command nosetests --with-gae --gae-lib-root=/b/google_appengine returned non-zero exit status 1 Traceback (most recent call last): File "/usr/local/bin/nosetests", line 5, in <module> from pkg_resources import load_entry_point File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 2707, in <module> working_set.require(__requires__) File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 686, in require needed = self.resolve(parse_requirements(requirements)) File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 584, in resolve raise DistributionNotFound(req) pkg_resources.DistributionNotFound: nose==1.1.2 Pylint (11 files) failed ************* Module app_test F0401: 79,4:MainTestCase.test_main_page_redirect: Unable to import 'webtest' F0401: 99,4:AppTestCase.test_app: Unable to import 'webtest' F0401:110,4:AppTestCase.test_app_blob: Unable to import 'webtest' F0401:121,4:AppTestCase.test_app_unicode: Unable to import 'webtest' F0401:133,4:AppTestCase.test_app_unicode_blob: Unable to import 'webtest' F0401:146,4:AppTestCase.test_app_cp1252: Unable to import 'webtest' F0401:158,4:AppTestCase.test_app_cp1252_blob: Unable to import 'webtest' F0401:172,4:AppTestCase.test_app_bogus_query_string: Unable to import 'webtest' F0401:173,4:AppTestCase.test_app_bogus_query_string: Unable to import 'webtest' Presubmit checks took 12.4s to calculate.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/23033018/6001
Presubmit check for 23033018-6001 failed and returned exit status 1. Running presubmit commit checks ... ** Presubmit ERRORS ** nosetests failed! Command nosetests --with-gae --gae-lib-root=/b/google_appengine returned non-zero exit status 1 Traceback (most recent call last): File "/usr/local/bin/nosetests", line 5, in <module> from pkg_resources import load_entry_point File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 2707, in <module> working_set.require(__requires__) File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 686, in require needed = self.resolve(parse_requirements(requirements)) File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 584, in resolve raise DistributionNotFound(req) pkg_resources.DistributionNotFound: nose==1.1.2 Pylint (11 files) failed ************* Module app_test F0401: 79,4:MainTestCase.test_main_page_redirect: Unable to import 'webtest' F0401: 99,4:AppTestCase.test_app: Unable to import 'webtest' F0401:110,4:AppTestCase.test_app_blob: Unable to import 'webtest' F0401:121,4:AppTestCase.test_app_unicode: Unable to import 'webtest' F0401:133,4:AppTestCase.test_app_unicode_blob: Unable to import 'webtest' F0401:146,4:AppTestCase.test_app_cp1252: Unable to import 'webtest' F0401:158,4:AppTestCase.test_app_cp1252_blob: Unable to import 'webtest' F0401:172,4:AppTestCase.test_app_bogus_query_string: Unable to import 'webtest' F0401:173,4:AppTestCase.test_app_bogus_query_string: Unable to import 'webtest' Presubmit checks took 6.4s to calculate. Was the presubmit check useful? Please send feedback & hate mail to maruel@chromium.org!
Message was sent while issue was closed.
Committed patchset #4 manually as r234985.
Message was sent while issue was closed.
Looks like this patch breaks local presubmit, since the HTML expectations weren't retrained with the new output.
Message was sent while issue was closed.
On 2013/12/16 20:47:46, stip wrote: > Looks like this patch breaks local presubmit, since the HTML expectations > weren't retrained with the new output. i don't know if it even works, build.chromium.org still has a "-->" so you can revert if you'd like |