[password autofill] Add serialization for FormData and FormFieldData

components/autofill/core/common/form_data.h

Index: components/autofill/core/common/form_data.h
diff --git a/components/autofill/core/common/form_data.h b/components/autofill/core/common/form_data.h
index 202fb8d3f95906782e281d858c5b1c66385ee6ee..7690cee9246be6bcc357fa19e712cb8ab74ddec5 100644
--- a/components/autofill/core/common/form_data.h
+++ b/components/autofill/core/common/form_data.h
@@ -37,6 +37,11 @@ struct FormData {
   std::vector<FormFieldData> fields;
 };
 
+// Serialize and deserialize FormData. Used by the PasswordManager to persist
+// FormData pertaining to password forms.
+void SerializeFormData(const FormData& form_data, Pickle* pickle);

[Evan Stade, 2013/08/26 23:20:44]

any reason not to make this return a scoped_ptr<Pickle>?

[Garrett Casto, 2013/08/27 17:21:05]

One of the PasswordStore implementations (NativeBackendKWallet) Pickles the
entire PasswordForm, so we want to be able to append to that Pickle.

[Evan Stade, 2013/08/28 22:42:11]

can you improve the comment then? Something along the lines of:

Serialized data will be appended to |pickle|.

[Garrett Casto, 2013/08/29 06:48:34]

Done.

+bool DeserializeFormData(PickleIterator* iter, FormData* form_data);

[Evan Stade, 2013/08/26 23:20:44]

Why does this take a PickleIterator* instead of const Pickle&?

[Garrett Casto, 2013/08/27 17:21:05]

Same reason, we want to deserialize part of a Pickle as a FormData, not
necessarily the whole thing.

[Evan Stade, 2013/08/28 22:42:11]

also needs better comments.

[Garrett Casto, 2013/08/29 06:48:34]

Done.

+
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_COMMON_FORM_DATA_H__