[password autofill] Add serialization for FormData and FormFieldData

components/autofill/core/common/form_data.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_FORM_DATA_H__
 #define COMPONENTS_AUTOFILL_CORE_COMMON_FORM_DATA_H__
 
 #include <vector>
 
 #include "base/strings/string16.h"
@@ skipping 19 matching lines @@
   // The URL (minus query parameters) containing the form.
   GURL origin;
   // The action target of the form.
   GURL action;
   // true if this form was submitted by a user gesture and not javascript.
   bool user_submitted;
   // A vector of all the input fields in the form.
   std::vector<FormFieldData> fields;
 };
 
+// Serialize and deserialize FormData. Used by the PasswordManager to persist
+// FormData pertaining to password forms.
+void SerializeFormData(const FormData& form_data, Pickle* pickle);

[Evan Stade, 2013/08/26 23:20:44]

any reason not to make this return a scoped_ptr<Pickle>?

[Garrett Casto, 2013/08/27 17:21:05]

One of the PasswordStore implementations (NativeBackendKWallet) Pickles the
entire PasswordForm, so we want to be able to append to that Pickle.

[Evan Stade, 2013/08/28 22:42:11]

can you improve the comment then? Something along the lines of:

Serialized data will be appended to |pickle|.

[Garrett Casto, 2013/08/29 06:48:34]

Done.

+bool DeserializeFormData(PickleIterator* iter, FormData* form_data);

[Evan Stade, 2013/08/26 23:20:44]

Why does this take a PickleIterator* instead of const Pickle&?

[Garrett Casto, 2013/08/27 17:21:05]

Same reason, we want to deserialize part of a Pickle as a FormData, not
necessarily the whole thing.

[Evan Stade, 2013/08/28 22:42:11]

also needs better comments.

[Garrett Casto, 2013/08/29 06:48:34]

Done.

+
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_COMMON_FORM_DATA_H__