Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2303163002: Update web_command code so that it continues to use the legacy module loader. Drive by removal of m… (Closed)

Created:
4 years, 3 months ago by Jacob
Modified:
4 years, 3 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update web_command code so that it continues to use the legacy module loader. Drive by removal of misleading comments. BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/38724f06267ee03028e99318ad21f50a535d28da

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update web_command code so that it continues to use the legacy module loader. Drive by removal of m… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -117 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 1 9 chunks +30 lines, -15 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 1 9 chunks +30 lines, -15 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 1 9 chunks +30 lines, -15 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 1 9 chunks +30 lines, -15 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart View 1 6 chunks +22 lines, -14 lines 0 comments Download
M pkg/dev_compiler/web/main.dart View 2 chunks +1 line, -33 lines 0 comments Download
M pkg/dev_compiler/web/web_command.dart View 3 chunks +23 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jacob
Also cleanup debugger profiling code to have a bit more structure. Stripped out name that ...
4 years, 3 months ago (2016-09-02 01:42:19 UTC) #2
Jennifer Messerly
lgtm https://codereview.chromium.org/2303163002/diff/1/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart (right): https://codereview.chromium.org/2303163002/diff/1/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart#newcode202 pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart:202: keys.sort((a, b) => _callMethodStats[b].count.compareTo(_callMethodStats[a].count)); long line (we sadly ...
4 years, 3 months ago (2016-09-06 16:34:30 UTC) #3
Jacob
https://codereview.chromium.org/2303163002/diff/1/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart (right): https://codereview.chromium.org/2303163002/diff/1/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart#newcode202 pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart:202: keys.sort((a, b) => _callMethodStats[b].count.compareTo(_callMethodStats[a].count)); On 2016/09/06 16:34:29, John Messerly ...
4 years, 3 months ago (2016-09-06 16:37:02 UTC) #4
Jacob
4 years, 3 months ago (2016-09-06 16:57:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
38724f06267ee03028e99318ad21f50a535d28da (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698