Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1444)

Unified Diff: pkg/dev_compiler/web/main.dart

Issue 2303163002: Update web_command code so that it continues to use the legacy module loader. Drive by removal of m… (Closed)
Patch Set: Update web_command code so that it continues to use the legacy module loader. Drive by removal of m… Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/web/main.dart
diff --git a/pkg/dev_compiler/web/main.dart b/pkg/dev_compiler/web/main.dart
index ebf3a91891137936405883c78f5a29686d58fe7a..2216580b3d5ef07decfc60a61385c52d37125fbd 100755
--- a/pkg/dev_compiler/web/main.dart
+++ b/pkg/dev_compiler/web/main.dart
@@ -3,38 +3,6 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-/// Command line entry point for Dart Development Compiler (dartdevc).
-///
-/// Supported commands are
-/// * compile: builds a collection of dart libraries into a single JS module
-///
-/// Additionally, these commands are being considered
-/// * link: combines several JS modules into a single JS file
-/// * build: compiles & links a set of code, automatically determining
-/// appropriate groupings of libraries to combine into JS modules
-/// * watch: watch a directory and recompile build units automatically
-/// * serve: uses `watch` to recompile and exposes a simple static file server
-/// for local development
-///
-/// These commands are combined so we have less names to expose on the PATH,
-/// and for development simplicity while the precise UI has not been determined.
-///
-/// A more typical structure for web tools is simply to have the compiler with
-/// "watch" as an option. The challenge for us is:
-///
-/// * Dart used to assume whole-program compiles, so we don't have a
-/// user-declared unit of building, and neither "libraries" or "packages" will
-/// work,
-/// * We do not assume a `node` JS installation, so we cannot easily reuse
-/// existing tools for the "link" step, or assume users have a local
-/// file server,
-/// * We didn't have a file watcher API at first,
-/// * We had no conventions about where compiled output should go (or even
-/// that we would be compiling at all, vs running on an in-browser Dart VM),
-/// * We wanted a good first impression with our simple examples, so we used
-/// local file servers, and users have an expectation of it now, even though
-/// it doesn't scale to typical apps that need their own real servers.
-
@JS()
library dev_compiler.web.main;
@@ -45,7 +13,7 @@ import 'package:js/js.dart';
import 'web_command.dart';
-@JS()
+@JS(r'$setUpDartDevCompilerInBrowser')
external set setUpCompilerInBrowser(Function function);
Future main() async {
« no previous file with comments | « pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart ('k') | pkg/dev_compiler/web/web_command.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698