Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: chrome/browser/resources/settings/internet_page/network_property_list.html

Issue 2303093003: MD Settings: Internet: Enable SIM unlock with no cellular network (Closed)
Patch Set: Feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/internet_page/network_property_list.html
diff --git a/chrome/browser/resources/settings/internet_page/network_property_list.html b/chrome/browser/resources/settings/internet_page/network_property_list.html
index 53176057b158e10ca0b5ee1d8cdca57c3f96a5cd..d50637295591db12757fcc6ee6e4bd6d556a7cd4 100644
--- a/chrome/browser/resources/settings/internet_page/network_property_list.html
+++ b/chrome/browser/resources/settings/internet_page/network_property_list.html
@@ -13,10 +13,20 @@
margin-bottom: -12px;
margin-top: -8px;
}
+
+ /* Property lists are embedded; stretch the box and remove the padding. */
+ .settings-box {
+ align-items: stretch;
+ padding: 0;
+ }
+
+ .settings-box:first-of-type {
michaelpg 2016/09/15 02:24:28 I suppose I've already argued my case, but it woul
stevenjb 2016/09/15 17:42:17 While I completely agree that we should not do thi
michaelpg 2016/09/15 21:35:16 No, this is my preferred solution! I was just lame
+ border-top: none;
+ }
</style>
<template is="dom-repeat" items="[[fields]]"
filter="[[computeFilter_(propertyDict, editFieldTypes)]]">
- <div class="settings-box single-column">
+ <div class="settings-box single-column two-line">
<!-- Propety label -->
<div>[[getPropertyLabel_(item, prefix)]]</div>
<!-- Uneditable property value -->

Powered by Google App Engine
This is Rietveld 408576698