Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: chrome/browser/resources/settings/internet_page/network_property_list.html

Issue 2303093003: MD Settings: Internet: Enable SIM unlock with no cellular network (Closed)
Patch Set: Feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/network/cr_onc_types.htm l"> 1 <link rel="import" href="chrome://resources/cr_elements/network/cr_onc_types.htm l">
2 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_network _behavior.html"> 2 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_network _behavior.html">
3 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_network _indicator.html"> 3 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_network _indicator.html">
4 <link rel="import" href="chrome://resources/html/i18n_behavior.html"> 4 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
5 <link rel="import" href="chrome://resources/html/polymer.html"> 5 <link rel="import" href="chrome://resources/html/polymer.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input -container.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input -container.html">
7 <link rel="import" href="internet_shared_css.html"> 7 <link rel="import" href="internet_shared_css.html">
8 8
9 <dom-module name="network-property-list"> 9 <dom-module name="network-property-list">
10 <template> 10 <template>
11 <style include="internet-shared"> 11 <style include="internet-shared">
12 paper-input-container { 12 paper-input-container {
13 margin-bottom: -12px; 13 margin-bottom: -12px;
14 margin-top: -8px; 14 margin-top: -8px;
15 } 15 }
16
17 /* Property lists are embedded; stretch the box and remove the padding. */
18 .settings-box {
19 align-items: stretch;
20 padding: 0;
21 }
22
23 .settings-box:first-of-type {
michaelpg 2016/09/15 02:24:28 I suppose I've already argued my case, but it woul
stevenjb 2016/09/15 17:42:17 While I completely agree that we should not do thi
michaelpg 2016/09/15 21:35:16 No, this is my preferred solution! I was just lame
24 border-top: none;
25 }
16 </style> 26 </style>
17 <template is="dom-repeat" items="[[fields]]" 27 <template is="dom-repeat" items="[[fields]]"
18 filter="[[computeFilter_(propertyDict, editFieldTypes)]]"> 28 filter="[[computeFilter_(propertyDict, editFieldTypes)]]">
19 <div class="settings-box single-column"> 29 <div class="settings-box single-column two-line">
20 <!-- Propety label --> 30 <!-- Propety label -->
21 <div>[[getPropertyLabel_(item, prefix)]]</div> 31 <div>[[getPropertyLabel_(item, prefix)]]</div>
22 <!-- Uneditable property value --> 32 <!-- Uneditable property value -->
23 <div class="layout horizontal" 33 <div class="layout horizontal"
24 hidden$="[[isEditable_(item, '', propertyDict, editFieldTypes)]]"> 34 hidden$="[[isEditable_(item, '', propertyDict, editFieldTypes)]]">
25 <div class="secondary">[[getPropertyValue_(item, propertyDict)]]</div> 35 <div class="secondary">[[getPropertyValue_(item, propertyDict)]]</div>
26 <cr-policy-network-indicator property="[[propertyDict]]"> 36 <cr-policy-network-indicator property="[[propertyDict]]">
27 </cr-policy-network-indicator> 37 </cr-policy-network-indicator>
28 </div> 38 </div>
29 <!-- Editable string property value --> 39 <!-- Editable string property value -->
30 <div class="layout horizontal" hidden$="[[!isEditable_( 40 <div class="layout horizontal" hidden$="[[!isEditable_(
31 item, 'String', propertyDict, editFieldTypes)]]"> 41 item, 'String', propertyDict, editFieldTypes)]]">
32 <paper-input-container no-label-float> 42 <paper-input-container no-label-float>
33 <input id="[[item]]" is="iron-input" 43 <input id="[[item]]" is="iron-input"
34 value="[[getPropertyValue_(item, propertyDict)]]" 44 value="[[getPropertyValue_(item, propertyDict)]]"
35 on-blur="onValueChange_"> 45 on-blur="onValueChange_">
36 </paper-input-container> 46 </paper-input-container>
37 </div> 47 </div>
38 <!-- TODO(stevenjb): Support non-string types --> 48 <!-- TODO(stevenjb): Support non-string types -->
39 </div> 49 </div>
40 </template> 50 </template>
41 </template> 51 </template>
42 <script src="network_property_list.js"></script> 52 <script src="network_property_list.js"></script>
43 </dom-module> 53 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698