Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Unified Diff: tools/determinism/compare_build_artifacts.py

Issue 2303063003: Skip COFF timestamp difference. (Closed)
Patch Set: skip only if windows. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/determinism/compare_build_artifacts.py
diff --git a/tools/determinism/compare_build_artifacts.py b/tools/determinism/compare_build_artifacts.py
index d486cb99db63af1ac1eaa66dcce8164b7e3b6d87..8c57e5b2a7f34b31bdb25bc6a25e7e3bade6b8cd 100755
--- a/tools/determinism/compare_build_artifacts.py
+++ b/tools/determinism/compare_build_artifacts.py
@@ -543,6 +543,7 @@ def get_deps(build_dir, target):
def compare_deps(first_dir, second_dir, targets):
"""Print difference of dependent files."""
+ COFF_TIMESTAMP_DIFF_PATTERN = re.compile(r'[1-3] out of ')
for target in targets:
first_deps = get_deps(first_dir, target)
second_deps = get_deps(second_dir, target)
@@ -559,7 +560,10 @@ def compare_deps(first_dir, second_dir, targets):
second_file = os.path.join(second_dir, d)
result = compare_files(first_file, second_file)
if result:
- print('%-*s: %s' % (max_filepath_len, d, result))
+ if (sys.platform == 'win32' and
M-A Ruel 2016/09/02 16:30:26 This code belongs to binary_diff(); should passlis
Yoshisato Yanagisawa 2016/09/05 02:44:25 I cannot catch what you mean exactly but I guess y
+ COFF_TIMESTAMP_DIFF_PATTERN.match(result)):
+ continue
+ print(' %-*s: %s' % (max_filepath_len, d, result))
def compare_build_artifacts(first_dir, second_dir, target_platform,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698