Skip COFF timestamp difference.

tools/determinism/compare_build_artifacts.py

 #!/usr/bin/env python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Compare the artifacts from two builds."""
 
 import difflib
 import json
 import optparse
@@ skipping 525 matching lines @@
       if os.path.isabs(path):
         print >> sys.stderr, ('not support abs path %s used for target %s'
                               % (path, target))
         continue
       files.append(path)
   return files
 
 
 def compare_deps(first_dir, second_dir, targets):
   """Print difference of dependent files."""
+  COFF_TIMESTAMP_DIFF_PATTERN = re.compile(r'[1-3] out of ')
   for target in targets:
     first_deps = get_deps(first_dir, target)
     second_deps = get_deps(second_dir, target)
     print 'Checking %s difference: (%s deps)' % (target, len(first_deps))
     if set(first_deps) != set(second_deps):
       # Since we do not thiks this case occur, we do not do anything special
       # for this case.
       print 'deps on %s are different: %s' % (
           target, set(first_deps).symmetric_difference(set(second_deps)))
       continue
     max_filepath_len = max(len(n) for n in first_deps)
     for d in first_deps:
       first_file = os.path.join(first_dir, d)
       second_file = os.path.join(second_dir, d)
       result = compare_files(first_file, second_file)
       if result:
-        print('%-*s: %s' % (max_filepath_len, d, result))
+        if (sys.platform == 'win32' and

[M-A Ruel, 2016/09/02 16:30:26]

This code belongs to binary_diff(); should passlist the allowed extentions.

[Yoshisato Yanagisawa, 2016/09/05 02:44:25]

I cannot catch what you mean exactly but I guess you might saying that doing
this kinds of check in diff_binary instead of here, right?

Let me revise the code like so.

+            COFF_TIMESTAMP_DIFF_PATTERN.match(result)):
+          continue
+        print('  %-*s: %s' % (max_filepath_len, d, result))
 
 
 def compare_build_artifacts(first_dir, second_dir, target_platform,
                             recursive=False):
   """Compares the artifacts from two distinct builds."""
   if not os.path.isdir(first_dir):
     print >> sys.stderr, '%s isn\'t a valid directory.' % first_dir
     return 1
   if not os.path.isdir(second_dir):
     print >> sys.stderr, '%s isn\'t a valid directory.' % second_dir
@@ skipping 85 matching lines @@
     parser.error('--target-platform is required')
 
   return compare_build_artifacts(os.path.abspath(options.first_build_dir),
                                  os.path.abspath(options.second_build_dir),
                                  options.target_platform,
                                  options.recursive)
 
 
 if __name__ == '__main__':
   sys.exit(main())