Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Issue 2303053002: Revert of Use webrtc::VideoFrame timestamp in RTCVideoEncoder (patchset #7 id:260001 of https://cod… (Closed)

Created:
4 years, 3 months ago by emircan
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Revert of Use webrtc::VideoFrame timestamp in RTCVideoEncoder (patchset #7 id:260001 of https://codereview.chromium.org/2205623002/ ) Reason for revert: This CL caused some regressions regarding BWE stats and HW encoder performance. Reasons include: 1) Modifying scoped_refptr<media::VideoFrame>'s timestamp causes problems for other clients using the same media::VideoFrame. 2) WebRTC's RTP timestamp isn't suitable for using as presentation timestamp in Mac and Win HW encoders. BUG=641230 Original issue's description: > Use webrtc::VideoFrame timestamp in RTCVideoEncoder > > This CL fixes input timestamp mismatch in RTCVideoEncoder, which > broke googAvgEncodeMs and googEncodeUsagePercent stats in webrtc-internals > for hardware encoders. > With this change, we start using WebRTC given timestamp() so that > OveruseFrameDetector can match the timestamps and calculate the stats. > > BUG=597087 > TEST=googAvgEncodeMs and googEncodeUsagePercent works on Mac(H264) and > veyron_jerry(VP8). > > Committed: https://crrev.com/e3195490a63d9545fb1bfe560aa21680ba0b5843 > Cr-Commit-Position: refs/heads/master@{#414589} TBR=wuchengli@chromium.org,pbos@chromium.org,posciak@chromium.org BUG=597087 Review-Url: https://codereview.chromium.org/2296273002 Cr-Commit-Position: refs/heads/master@{#415752} (cherry picked from commit eb436ddb8b313a81e758b5c5f97ca4349b5203a0) NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -35 lines) Patch
M content/renderer/media/gpu/rtc_video_encoder.cc View 4 chunks +15 lines, -17 lines 0 comments Download
M media/gpu/video_encode_accelerator_unittest.cc View 3 chunks +2 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2303053002/1
4 years, 3 months ago (2016-09-01 21:29:19 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 21:33:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698