Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2296273002: Revert of Use webrtc::VideoFrame timestamp in RTCVideoEncoder (Closed)

Created:
4 years, 3 months ago by emircan
Modified:
4 years, 3 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use webrtc::VideoFrame timestamp in RTCVideoEncoder (patchset #7 id:260001 of https://codereview.chromium.org/2205623002/ ) Reason for revert: This CL caused some regressions regarding BWE stats and HW encoder performance. Reasons include: 1) Modifying scoped_refptr<media::VideoFrame>'s timestamp causes problems for other clients using the same media::VideoFrame. 2) WebRTC's RTP timestamp isn't suitable for using as presentation timestamp in Mac and Win HW encoders. BUG=641230 Original issue's description: > Use webrtc::VideoFrame timestamp in RTCVideoEncoder > > This CL fixes input timestamp mismatch in RTCVideoEncoder, which > broke googAvgEncodeMs and googEncodeUsagePercent stats in webrtc-internals > for hardware encoders. > With this change, we start using WebRTC given timestamp() so that > OveruseFrameDetector can match the timestamps and calculate the stats. > > BUG=597087 > TEST=googAvgEncodeMs and googEncodeUsagePercent works on Mac(H264) and > veyron_jerry(VP8). > > Committed: https://crrev.com/e3195490a63d9545fb1bfe560aa21680ba0b5843 > Cr-Commit-Position: refs/heads/master@{#414589} TBR=wuchengli@chromium.org,pbos@chromium.org,posciak@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=597087 Committed: https://crrev.com/eb436ddb8b313a81e758b5c5f97ca4349b5203a0 Cr-Commit-Position: refs/heads/master@{#415752}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -36 lines) Patch
M content/renderer/media/gpu/rtc_video_encoder.cc View 4 chunks +16 lines, -18 lines 0 comments Download
M media/gpu/video_encode_accelerator_unittest.cc View 3 chunks +2 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
emircan
Created Revert of Use webrtc::VideoFrame timestamp in RTCVideoEncoder
4 years, 3 months ago (2016-08-31 17:53:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296273002/1
4 years, 3 months ago (2016-08-31 17:54:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 21:14:55 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 21:17:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb436ddb8b313a81e758b5c5f97ca4349b5203a0
Cr-Commit-Position: refs/heads/master@{#415752}

Powered by Google App Engine
This is Rietveld 408576698