chrome/test/data/safe_browsing/download_protection/navigation_observer/iframe_retargeting.html - Issue 2302913003: Add SafeBrowsingNavigationObserver to listen to navigation events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/safe_browsing/download_protection/navigation_observer/iframe_retargeting.html

Issue 2302913003: Add SafeBrowsingNavigationObserver to listen to navigation events (Closed)

Patch Set: refine comments and format Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc ('K') | « chrome/test/data/safe_browsing/download_protection/navigation_observer/iframe.html ('k') | chrome/test/data/safe_browsing/download_protection/navigation_observer/navigation_observer_multi_frame_tests.html » ('j') | chrome/test/data/safe_browsing/download_protection/navigation_observer/navigation_observer_tests.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/safe_browsing/download_protection/navigation_observer/iframe_retargeting.html

diff --git a/chrome/test/data/safe_browsing/download_protection/navigation_observer/iframe_retargeting.html b/chrome/test/data/safe_browsing/download_protection/navigation_observer/iframe_retargeting.html

new file mode 100644

index 0000000000000000000000000000000000000000..4021c88e9bc968416cfbe3762bdd128a9a96851f

--- /dev/null

+++ b/chrome/test/data/safe_browsing/download_protection/navigation_observer/iframe_retargeting.html

@@ -0,0 +1,15 @@

+<html>

+ <head>

+ <script>

+ function openInNewTab() {

+ var tab = window.open('navigation_observer_tests.html');

Charlie Reis 2016/11/03 22:58:45 What was the reason for changing this test?

Jialiu Lin 2016/11/04 05:38:01 Changed it back after using StartWatchingNewWebCon

+ tab.opener = null;

+ }

+ </script>

+ </head>

+ <body>

+ <a id="iframe_new_tab_navigation" href="#" onclick="openInNewTab(); return false;">

+ Open target url in new tab frome an iframe

+ </a><br>

+ </body>

+</html>