chrome/test/data/safe_browsing/download_protection/navigation_observer/iframe_retargeting.html - Issue 2302913003: Add SafeBrowsingNavigationObserver to listen to navigation events

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/safe_browsing/download_protection/navigation_observer/iframe_retargeting.html

Issue 2302913003: Add SafeBrowsingNavigationObserver to listen to navigation events (Closed)

Patch Set: refine comments and format Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script>

	4 function openInNewTab() {

	5 var tab = window.open('navigation_observer_tests.html');
	Charlie Reis 2016/11/03 22:58:45 What was the reason for changing this test? What was the reason for changing this test? Jialiu Lin 2016/11/04 05:38:01 Changed it back after using StartWatchingNewWebCon Show quoted text On 2016/11/03 22:58:45, Charlie Reis wrote: > What was the reason for changing this test? Changed it back after using StartWatchingNewWebContents().
	6 tab.opener = null;

	7 }

	8 </script>

	9 </head>

	10 <body>

	11 <a id="iframe_new_tab_navigation" href="#" onclick="openInNewTab(); return f alse;">

	12 Open target url in new tab frome an iframe

	13 </a><br>

	14 </body>

	15 </html>

OLD	NEW