Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2302773002: [regexp] Port RegExpConstructor (Closed)

Created:
4 years, 3 months ago by jgruber
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Port RegExpConstructor BUG=v8:5339 Committed: https://crrev.com/0aa80be16b8d876999066545c2922e1291e09610 Cr-Commit-Position: refs/heads/master@{#39074}

Patch Set 1 #

Patch Set 2 : Tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -52 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +15 lines, -6 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +3 lines, -0 lines 0 comments Download
A src/builtins/builtins-regexp.cc View 1 1 chunk +152 lines, -0 lines 0 comments Download
M src/heap-symbols.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/js/regexp.js View 10 chunks +7 lines, -46 lines 0 comments Download
M src/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (11 generated)
jgruber
4 years, 3 months ago (2016-09-01 10:10:04 UTC) #8
Benedikt Meurer
Awesome, almost ready to drop the JSBuiltinConstructStub! LGTM.
4 years, 3 months ago (2016-09-01 10:29:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302773002/20001
4 years, 3 months ago (2016-09-01 10:37:00 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-01 10:39:21 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0aa80be16b8d876999066545c2922e1291e09610 Cr-Commit-Position: refs/heads/master@{#39074}
4 years, 3 months ago (2016-09-01 10:39:44 UTC) #16
jgruber
4 years, 3 months ago (2016-09-05 13:54:18 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2312743002/ by jgruber@chromium.org.

The reason for reverting is: Performance regressions: crbug.com/644087
Clusterfuzz: crbug.com/644074

We'll reland all regexp changes at once when the port is complete and at least
performance-neutral, since the partial port requires slow workarounds..

Powered by Google App Engine
This is Rietveld 408576698