[regexp] Port RegExp getters and setters

[regexp] Port RegExp getters and setters

BUG=v8:5339
Committed: https://crrev.com/ac0eb5e05af40e16ae9402bb8a62600b32cc2ec9
Committed: https://crrev.com/7711b1a16f864ed6ea56fa40274ff3f6287bbe34
Cr-Original-Commit-Position: refs/heads/master@{#39076}
Cr-Commit-Position: refs/heads/master@{#39088}

[jgruber, 2016-09-01 09:10:41]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 09:10:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-09-01 09:27:12]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 09:27:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-09-01 10:10:27]

jgruber@chromium.org changed reviewers:
+ bmeurer@chromium.org

[commit-bot: I haz the power, 2016-09-01 10:11:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 10:11:50]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-09-01 10:20:50]

Description was changed from

==========
[regexp] Port RegExp getters and setters

BUG=
==========

to

==========
[regexp] Port RegExp getters and setters

BUG=v8:5339
==========

[Benedikt Meurer, 2016-09-01 10:22:34]

Very nice, just nits. As discussed offline, please create a tracking bug for
this work and reference it via the BUG= line.
Otherwise LGTM.

https://codereview.chromium.org/2305573002/diff/20001/src/accessors.cc
File src/accessors.cc (right):

https://codereview.chromium.org/2305573002/diff/20001/src/accessors.cc#newcode18
src/accessors.cc:18: #include "src/string-builder.h"
Why is this necessary?

https://codereview.chromium.org/2305573002/diff/20001/src/builtins/builtins-r...
File src/builtins/builtins-regexp.cc (right):

https://codereview.chromium.org/2305573002/diff/20001/src/builtins/builtins-r...
src/builtins/builtins-regexp.cc:249: // TODO(jgruber): Move to C++.
This is C++?

https://codereview.chromium.org/2305573002/diff/20001/src/builtins/builtins-r...
src/builtins/builtins-regexp.cc:250: static const int kNumberOfCapturesIndex =
0;
Nit: You don't need static inside anonymous namespace.

[jgruber, 2016-09-01 10:36:39]

https://codereview.chromium.org/2305573002/diff/20001/src/accessors.cc
File src/accessors.cc (right):

https://codereview.chromium.org/2305573002/diff/20001/src/accessors.cc#newcode18
src/accessors.cc:18: #include "src/string-builder.h"
On 2016/09/01 10:22:33, Benedikt Meurer wrote:
> Why is this necessary?

Done.

https://codereview.chromium.org/2305573002/diff/20001/src/builtins/builtins-r...
File src/builtins/builtins-regexp.cc (right):

https://codereview.chromium.org/2305573002/diff/20001/src/builtins/builtins-r...
src/builtins/builtins-regexp.cc:249: // TODO(jgruber): Move to C++.
On 2016/09/01 10:22:34, Benedikt Meurer wrote:
> This is C++?

The comment is about moving the RegExpLastMatchInfo object to C++. Currently,
it's still a JSObject maintained and accessed from JS. This is a crutch until
all RegExp logic is ported, then we can take care of RegExpLastMatchInfo.

Made the comment clearer.

https://codereview.chromium.org/2305573002/diff/20001/src/builtins/builtins-r...
src/builtins/builtins-regexp.cc:250: static const int kNumberOfCapturesIndex =
0;
On 2016/09/01 10:22:33, Benedikt Meurer wrote:
> Nit: You don't need static inside anonymous namespace.

Done.

[jgruber, 2016-09-01 10:43:41]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2016-09-01 10:43:42]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2305573002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-09-01 10:43:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 11:21:43]

Description was changed from

==========
[regexp] Port RegExp getters and setters

BUG=v8:5339
==========

to

==========
[regexp] Port RegExp getters and setters

BUG=v8:5339
==========

[commit-bot: I haz the power, 2016-09-01 11:21:43]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-01 11:22:29]

Description was changed from

==========
[regexp] Port RegExp getters and setters

BUG=v8:5339
==========

to

==========
[regexp] Port RegExp getters and setters

BUG=v8:5339

Committed: https://crrev.com/ac0eb5e05af40e16ae9402bb8a62600b32cc2ec9
Cr-Commit-Position: refs/heads/master@{#39076}
==========

[commit-bot: I haz the power, 2016-09-01 11:22:30]

Patchset 4 (id:??) landed as
https://crrev.com/ac0eb5e05af40e16ae9402bb8a62600b32cc2ec9
Cr-Commit-Position: refs/heads/master@{#39076}

[Michael Achenbach, 2016-09-01 12:50:12]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2301963002/ by machenbach@chromium.org.

The reason for reverting is: Breaks layout tests:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui....

[jgruber, 2016-09-01 13:05:20]

Description was changed from

==========
[regexp] Port RegExp getters and setters

BUG=v8:5339

Committed: https://crrev.com/ac0eb5e05af40e16ae9402bb8a62600b32cc2ec9
Cr-Commit-Position: refs/heads/master@{#39076}
==========

to

==========
[regexp] Port RegExp getters and setters

BUG=v8:5339

Committed: https://crrev.com/ac0eb5e05af40e16ae9402bb8a62600b32cc2ec9
Cr-Commit-Position: refs/heads/master@{#39076}
==========

[jgruber, 2016-09-01 13:12:47]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2016-09-01 13:12:48]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2305573002/#ps80001
(title: "Fix for layout test expectations")

[commit-bot: I haz the power, 2016-09-01 13:12:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 13:41:03]

Description was changed from

==========
[regexp] Port RegExp getters and setters

BUG=v8:5339

Committed: https://crrev.com/ac0eb5e05af40e16ae9402bb8a62600b32cc2ec9
Cr-Commit-Position: refs/heads/master@{#39076}
==========

to

==========
[regexp] Port RegExp getters and setters

BUG=v8:5339

Committed: https://crrev.com/ac0eb5e05af40e16ae9402bb8a62600b32cc2ec9
Cr-Commit-Position: refs/heads/master@{#39076}
==========

[commit-bot: I haz the power, 2016-09-01 13:41:05]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-01 13:41:40]

Description was changed from

==========
[regexp] Port RegExp getters and setters

BUG=v8:5339

Committed: https://crrev.com/ac0eb5e05af40e16ae9402bb8a62600b32cc2ec9
Cr-Commit-Position: refs/heads/master@{#39076}
==========

to

==========
[regexp] Port RegExp getters and setters

BUG=v8:5339

Committed: https://crrev.com/ac0eb5e05af40e16ae9402bb8a62600b32cc2ec9
Committed: https://crrev.com/7711b1a16f864ed6ea56fa40274ff3f6287bbe34
Cr-Original-Commit-Position: refs/heads/master@{#39076}
Cr-Commit-Position: refs/heads/master@{#39088}
==========

[commit-bot: I haz the power, 2016-09-01 13:41:41]

Patchset 5 (id:??) landed as
https://crrev.com/7711b1a16f864ed6ea56fa40274ff3f6287bbe34
Cr-Commit-Position: refs/heads/master@{#39088}

[jgruber, 2016-09-05 13:10:34]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2313713002/ by jgruber@chromium.org.

The reason for reverting is: Performance regressions: crbug.com/644087
Clusterfuzz: crbug.com/644074

We'll reland all regexp changes at once when the port is complete and at least
performance-neutral, since the partial port requires slow workarounds..