Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5419)

Unified Diff: chrome/browser/ssl/captive_portal_blocking_page.cc

Issue 2302623002: Fix privacy policy link in captive portal interstitials. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/captive_portal_blocking_page.cc
diff --git a/chrome/browser/ssl/captive_portal_blocking_page.cc b/chrome/browser/ssl/captive_portal_blocking_page.cc
index 542a5b42532c868035b70bac2fa37d7f405157db..5809f494f4a378d26bdef4ffafcd53e8a8442e38 100644
--- a/chrome/browser/ssl/captive_portal_blocking_page.cc
+++ b/chrome/browser/ssl/captive_portal_blocking_page.cc
@@ -193,20 +193,18 @@ void CaptivePortalBlockingPage::CommandReceived(const std::string& command) {
int command_num = 0;
bool command_is_num = base::StringToInt(command, &command_num);
DCHECK(command_is_num) << command;
- // Any command other than "open the login page" is ignored.
if (command_num == security_interstitials::CMD_OPEN_LOGIN) {
RecordUMA(OPEN_LOGIN_PAGE);
CaptivePortalTabHelper::OpenLoginTabForWebContents(web_contents(), true);
+ return;
}
+ ssl_error_ui_->HandleCommand(
lgarron 2016/08/31 22:22:31 Is this a passthrough? (I also don't see `cmd`; d
meacer 2016/08/31 22:38:11 Sigh, I could have at least tried compiling this :
+ static_cast<security_interstitials::SecurityInterstitialCommands>(cmd));
}
void CaptivePortalBlockingPage::OnProceed() {
- if (cert_report_helper_) {
- // Finish collecting information about invalid certificates, if the
- // user opted in to.
- cert_report_helper_->FinishCertCollection(
- certificate_reporting::ErrorReport::USER_PROCEEDED);
- }
+ NOTREACHED()
+ << "Cannot proceed through the error on a captive portal interstitial."
}
void CaptivePortalBlockingPage::OnDontProceed() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698