Index: chrome/browser/ssl/captive_portal_blocking_page.cc |
diff --git a/chrome/browser/ssl/captive_portal_blocking_page.cc b/chrome/browser/ssl/captive_portal_blocking_page.cc |
index 542a5b42532c868035b70bac2fa37d7f405157db..5809f494f4a378d26bdef4ffafcd53e8a8442e38 100644 |
--- a/chrome/browser/ssl/captive_portal_blocking_page.cc |
+++ b/chrome/browser/ssl/captive_portal_blocking_page.cc |
@@ -193,20 +193,18 @@ void CaptivePortalBlockingPage::CommandReceived(const std::string& command) { |
int command_num = 0; |
bool command_is_num = base::StringToInt(command, &command_num); |
DCHECK(command_is_num) << command; |
- // Any command other than "open the login page" is ignored. |
if (command_num == security_interstitials::CMD_OPEN_LOGIN) { |
RecordUMA(OPEN_LOGIN_PAGE); |
CaptivePortalTabHelper::OpenLoginTabForWebContents(web_contents(), true); |
+ return; |
} |
+ ssl_error_ui_->HandleCommand( |
lgarron
2016/08/31 22:22:31
Is this a passthrough?
(I also don't see `cmd`; d
meacer
2016/08/31 22:38:11
Sigh, I could have at least tried compiling this :
|
+ static_cast<security_interstitials::SecurityInterstitialCommands>(cmd)); |
} |
void CaptivePortalBlockingPage::OnProceed() { |
- if (cert_report_helper_) { |
- // Finish collecting information about invalid certificates, if the |
- // user opted in to. |
- cert_report_helper_->FinishCertCollection( |
- certificate_reporting::ErrorReport::USER_PROCEEDED); |
- } |
+ NOTREACHED() |
+ << "Cannot proceed through the error on a captive portal interstitial." |
} |
void CaptivePortalBlockingPage::OnDontProceed() { |