Fix privacy policy link in captive portal interstitials.

chrome/browser/ssl/captive_portal_blocking_page.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ssl/captive_portal_blocking_page.h"
 
 #include <utility>
 
 #include "base/i18n/rtl.h"
 #include "base/metrics/histogram.h"
@@ skipping 175 matching lines @@
 
 void CaptivePortalBlockingPage::CommandReceived(const std::string& command) {
   if (command == "\"pageLoadComplete\"") {
     // content::WaitForRenderFrameReady sends this message when the page
     // load completes. Ignore it.
     return;
   }
   int command_num = 0;
   bool command_is_num = base::StringToInt(command, &command_num);
   DCHECK(command_is_num) << command;
-  // Any command other than "open the login page" is ignored.
   if (command_num == security_interstitials::CMD_OPEN_LOGIN) {
     RecordUMA(OPEN_LOGIN_PAGE);
     CaptivePortalTabHelper::OpenLoginTabForWebContents(web_contents(), true);
+    return;
   }
+  ssl_error_ui_->HandleCommand(

[lgarron, 2016/08/31 22:22:31]

Is this a passthrough?

(I also don't see `cmd`; did you mean `command`?)

[meacer, 2016/08/31 22:38:11]

Sigh, I could have at least tried compiling this :p Needs more work because
ssl_error_ui_ isn't available either.

+      static_cast<security_interstitials::SecurityInterstitialCommands>(cmd));
 }
 
 void CaptivePortalBlockingPage::OnProceed() {
-  if (cert_report_helper_) {
-    // Finish collecting information about invalid certificates, if the
-    // user opted in to.
-    cert_report_helper_->FinishCertCollection(
-        certificate_reporting::ErrorReport::USER_PROCEEDED);
-  }
+  NOTREACHED()
+      << "Cannot proceed through the error on a captive portal interstitial."
 }
 
 void CaptivePortalBlockingPage::OnDontProceed() {
   if (cert_report_helper_) {
     // Finish collecting information about invalid certificates, if the
     // user opted in to.
     cert_report_helper_->FinishCertCollection(
         certificate_reporting::ErrorReport::USER_DID_NOT_PROCEED);
   }
 
   // Need to explicity deny the certificate via the callback, otherwise memory
   // is leaked.
   if (!callback_.is_null()) {
     callback_.Run(content::CERTIFICATE_REQUEST_RESULT_TYPE_CANCEL);
     callback_.Reset();
   }
 }