Fix privacy policy link in captive portal interstitials.

Fix privacy policy link in captive portal interstitials.

BUG=642911
Committed: https://crrev.com/ee53d14732a274057e9ce51c1d07d87fc7ffc90e
Cr-Commit-Position: refs/heads/master@{#422634}

[meacer, 2016-08-31 22:12:58]

meacer@chromium.org changed reviewers:
+ lgarron@chromium.org

[meacer, 2016-08-31 22:12:58]

lgarron: PTAL?

[lgarron, 2016-08-31 22:22:31]

I'm not an OWNER, but looks alright, I guess. ;-)

https://codereview.chromium.org/2302623002/diff/1/chrome/browser/ssl/captive_...
File chrome/browser/ssl/captive_portal_blocking_page.cc (right):

https://codereview.chromium.org/2302623002/diff/1/chrome/browser/ssl/captive_...
chrome/browser/ssl/captive_portal_blocking_page.cc:201:
ssl_error_ui_->HandleCommand(
Is this a passthrough?

(I also don't see `cmd`; did you mean `command`?)

[meacer, 2016-08-31 22:38:11]

https://codereview.chromium.org/2302623002/diff/1/chrome/browser/ssl/captive_...
File chrome/browser/ssl/captive_portal_blocking_page.cc (right):

https://codereview.chromium.org/2302623002/diff/1/chrome/browser/ssl/captive_...
chrome/browser/ssl/captive_portal_blocking_page.cc:201:
ssl_error_ui_->HandleCommand(
On 2016/08/31 22:22:31, lgarron wrote:
> Is this a passthrough?
> 
> (I also don't see `cmd`; did you mean `command`?)

Sigh, I could have at least tried compiling this :p Needs more work because
ssl_error_ui_ isn't available either.

[meacer, 2016-09-03 00:29:50]

The CQ bit was checked by meacer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-03 00:30:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-03 00:32:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-03 00:32:48]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[meacer, 2016-09-06 17:59:46]

The CQ bit was checked by meacer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 18:00:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 18:49:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 18:49:16]

Dry run: This issue passed the CQ dry run.

[meacer, 2016-09-06 18:53:45]

Okay, this is ready for review now. It depends on crrev.com/2303413002 which
depends on crrev.com/2298613007:

crrev.com/2298613007 Use controller from SecurityInterstitialPage in derived
classes
crrev.com/2303413002 Simplify security_interstitials::ControllerClient and other
related classes

lgarron: PTAL?

[meacer, 2016-09-08 19:09:56]

On 2016/09/06 18:53:45, Mustafa Emre Acer wrote:
> Okay, this is ready for review now. It depends on crrev.com/2303413002 which
> depends on crrev.com/2298613007:
> 
> crrev.com/2298613007 Use controller from SecurityInterstitialPage in derived
> classes
> crrev.com/2303413002 Simplify security_interstitials::ControllerClient and
other
> related classes
> 
> lgarron: PTAL?

Ping

[meacer, 2016-09-08 19:09:56]

On 2016/09/06 18:53:45, Mustafa Emre Acer wrote:
> Okay, this is ready for review now. It depends on crrev.com/2303413002 which
> depends on crrev.com/2298613007:
> 
> crrev.com/2298613007 Use controller from SecurityInterstitialPage in derived
> classes
> crrev.com/2303413002 Simplify security_interstitials::ControllerClient and
other
> related classes
> 
> lgarron: PTAL?

Ping

[meacer, 2016-09-29 17:15:52]

This is now ready for review.

[lgarron, 2016-10-03 23:31:19]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[meacer, 2016-10-03 23:31:42]

The CQ bit was checked by meacer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 23:32:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lgarron, 2016-10-03 23:47:23]

LGTM assuming you want to collect the captive_portal metrics (per discussion in
person).

[meacer, 2016-10-03 23:52:54]

On 2016/10/03 23:47:23, lgarron wrote:
> LGTM assuming you want to collect the captive_portal metrics (per discussion
in
> person).

Looks like these two methods added here call metrics_helper:
controller()->SetReportingPreference
controller()->OpenExtendedReportingPrivacyPolicy

These calls only add a new |interstitial.captive_portal.interaction| histogram
which records whether the user clicked on the reporting checkbox. That sounds
like something we want, so I think we are good.

[meacer, 2016-10-04 00:29:11]

The CQ bit was unchecked by meacer@chromium.org

[meacer, 2016-10-04 00:29:16]

The CQ bit was checked by meacer@chromium.org

[commit-bot: I haz the power, 2016-10-04 00:30:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 00:38:30]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-10-04 00:42:11]

Description was changed from

==========
Fix privacy policy link in captive portal interstitials.

BUG=642911
==========

to

==========
Fix privacy policy link in captive portal interstitials.

BUG=642911

Committed: https://crrev.com/ee53d14732a274057e9ce51c1d07d87fc7ffc90e
Cr-Commit-Position: refs/heads/master@{#422634}
==========

[commit-bot: I haz the power, 2016-10-04 00:42:12]

Patchset 6 (id:??) landed as
https://crrev.com/ee53d14732a274057e9ce51c1d07d87fc7ffc90e
Cr-Commit-Position: refs/heads/master@{#422634}