Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: ui/android/java/res/layout/color_button_row.xml

Issue 23026006: Add support for color input datalist on Android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/android/java/res/layout/color_button_row.xml
diff --git a/ui/android/java/res/layout/color_button_row.xml b/ui/android/java/res/layout/color_button_row.xml
new file mode 100644
index 0000000000000000000000000000000000000000..4649c9230e3cdbe7f4825ec364a13d5c3c555012
--- /dev/null
+++ b/ui/android/java/res/layout/color_button_row.xml
@@ -0,0 +1,36 @@
+<?xml version="1.0" encoding="utf-8"?>
newt (away) 2013/10/09 06:07:03 I'd prefer if this were replaced with a Java class
+<!--
+ Copyright 2013 The Chromium Authors. All rights reserved.
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file.
+-->
+
+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+ android:orientation="horizontal"
newt (away) 2013/10/09 06:07:03 unindent by 4
keishi 2013/10/15 16:44:02 Done.
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content">
+
+ <View android:id="@+id/color_button_1"
+ android:background="@drawable/color_button_background"
+ android:layout_weight="1"
+ android:layout_width="wrap_content"
newt (away) 2013/10/09 06:07:03 layout_width should be 0dp for all of these color_
keishi 2013/10/15 16:44:02 Done.
+ android:layout_height="@dimen/color_button_height" />
+
+ <View android:id="@+id/color_button_2"
+ android:background="@drawable/color_button_background"
+ android:layout_weight="1"
+ android:layout_width="wrap_content"
+ android:layout_height="@dimen/color_button_height" />
+
+ <View android:id="@+id/color_button_3"
+ android:background="@drawable/color_button_background"
+ android:layout_weight="1"
+ android:layout_width="wrap_content"
+ android:layout_height="@dimen/color_button_height" />
+
+ <View android:id="@+id/color_button_4"
+ android:background="@drawable/last_color_button_background"
+ android:layout_weight="1"
+ android:layout_width="wrap_content"
+ android:layout_height="@dimen/color_button_height" />
+</LinearLayout>

Powered by Google App Engine
This is Rietveld 408576698