ui/android/java/res/layout/color_button_row.xml - Issue 23026006: Add support for color input datalist on Android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/android/java/res/layout/color_button_row.xml

Issue 23026006: Add support for color input datalist on Android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« ui/android/java/res/drawable/color_button_background.xml ('K') | « ui/android/java/res/drawable/last_color_button_background.xml ('k') | ui/android/java/res/layout/color_picker_dialog_content.xml » ('j') | ui/android/java/res/layout/color_picker_dialog_content.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>
	newt (away) 2013/10/09 06:07:03 I'd prefer if this were replaced with a Java class I'd prefer if this were replaced with a Java class that extends LinearLayout and inserts the child Views programmatically. This will let you control the number of color buttons with a runtime parameter (instead of fixing it to 4)
	2 <!--

	3 Copyright 2013 The Chromium Authors. All rights reserved.

	4 Use of this source code is governed by a BSD-style license that can be

	5 found in the LICENSE file.

	6 -->

	7

	8 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

	9 android:orientation="horizontal"
	newt (away) 2013/10/09 06:07:03 unindent by 4 unindent by 4 keishi 2013/10/15 16:44:02 Done. Show quoted text On 2013/10/09 06:07:03, newt wrote: > unindent by 4 Done.
	10 android:layout_width="match_parent"

	11 android:layout_height="wrap_content">

	12

	13 <View android:id="@+id/color_button_1"

	14 android:background="@drawable/color_button_background"

	15 android:layout_weight="1"

	16 android:layout_width="wrap_content"
	newt (away) 2013/10/09 06:07:03 layout_width should be 0dp for all of these color_ layout_width should be 0dp for all of these color_button views. layout_weight="1" will then ensure that each view gets 25% of the available width keishi 2013/10/15 16:44:02 Done. Show quoted text On 2013/10/09 06:07:03, newt wrote: > layout_width should be 0dp for all of these color_button views. > layout_weight="1" will then ensure that each view gets 25% of the available > width Done.
	17 android:layout_height="@dimen/color_button_height" />

	18

	19 <View android:id="@+id/color_button_2"

	20 android:background="@drawable/color_button_background"

	21 android:layout_weight="1"

	22 android:layout_width="wrap_content"

	23 android:layout_height="@dimen/color_button_height" />

	24

	25 <View android:id="@+id/color_button_3"

	26 android:background="@drawable/color_button_background"

	27 android:layout_weight="1"

	28 android:layout_width="wrap_content"

	29 android:layout_height="@dimen/color_button_height" />

	30

	31 <View android:id="@+id/color_button_4"

	32 android:background="@drawable/last_color_button_background"

	33 android:layout_weight="1"

	34 android:layout_width="wrap_content"

	35 android:layout_height="@dimen/color_button_height" />

	36 </LinearLayout>

OLD	NEW