Issue 2302503002: A11y improvements for quick unlock settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2302503002: A11y improvements for quick unlock settings (Closed)

Created:
4 years, 3 months ago by jdufault

Modified:
4 years, 3 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

A11y improvements for quick unlock settings 1. Make screen lock element tab reachable 2. Add a button on the overlay CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation BUG=641591 Review-Url: https://codereview.chromium.org/2280253002 Cr-Commit-Position: refs/heads/master@{#415080} (cherry picked from commit 52a7b63c62cead577ede092be908b7027e45e3cd) Committed: https://chromium.googlesource.com/chromium/src/+/1b7ad919aaa66eaa134f3dd95e26215a09202fe0

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -2 lines)			Patch
	M	chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.html	View		1 chunk	+10 lines, -1 line	0 comments	Download
	M	chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.js	View		2 chunks	+5 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

jdufault

4 years, 3 months ago (2016-08-31 17:46:28 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1b7ad919aaa66eaa134f3dd95e26215a09202fe0.